Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEI stop #1055

Merged
merged 1 commit into from
Sep 24, 2024
Merged

PEI stop #1055

merged 1 commit into from
Sep 24, 2024

Conversation

Itzo1978
Copy link
Contributor

Which mods are added by this PR?

It's a little help for positionning the PEI Plate

How was it tested?

On my machine (v2.3941) since october 2013

Any background context you want to provide?

The stop I've developed makes the Y position easier to see (especially on the 2.4 350).

Screenshots (if appropriate)

Presented in images in the readme

⚠️⚠️PLEASE READ AND COMPLETE THE CHECKLIST BELOW⚠️⚠️

  • I have read the rules available here and
    my mod adheres to these rules.
  • This mod was created by myself and I agree to publish it under the repository
    license

Copy link
Collaborator

@jontek2 jontek2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Itzo1978 Looks good, but could you update the name? It currently says "New mod : PEI Stop" but "PEI stop" would be better.

Copy link
Collaborator

@mjonuschat mjonuschat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Itzo1978 Itzo1978 changed the title New mod : PEI Stop PEI stop Sep 23, 2024
@Itzo1978
Copy link
Contributor Author

@Itzo1978 Looks good, but could you update the name? It currently says "New mod : PEI Stop" but "PEI stop" would be better.

Done ✅️

Copy link

Hi, thank you for submitting your PR.
Please find below the results of the automated PR checker:

Added/Changed mods detected in this PR:

Item Result Description/Error Printer compatibility/Error Detail
Itzo1978/PEI_Stop ✅ SUCCESS Stop for positioning your PEI V2.4r2

Tool check results overview:

Tool ⚠️ 💀
File checker 6 1
Readme generator 1
STL corruption checker 1
STL rotation checker 1
Mod structure checker

Tool check results details:

SUCCESS: ✅

File checker

Item Result Reason
Itzo1978/PEI_Stop/README.md ✅ SUCCESS
Itzo1978/PEI_Stop/.metadata.yml ✅ SUCCESS
Itzo1978/PEI_Stop/CAD/pei_stop_x2.step ✅ SUCCESS
Itzo1978/PEI_Stop/STL/pei_stop_x2.stl ✅ SUCCESS
Itzo1978/PEI_Stop/Images/pei_stop.gif ✅ SUCCESS
Itzo1978/PEI_Stop/Images/pei_stop.png ✅ SUCCESS

Readme generator

Item Result Description/Error Printer compatibility/Error Detail
Itzo1978/PEI_Stop ✅ SUCCESS Stop for positioning your PEI V2.4r2

STL corruption checker

Item Result Number of STL fixes applicable
pei_stop_x2.stl ✅ SUCCESS 0

STL rotation checker

Item Result Original orientation Suggested orientation
pei_stop_x2.stl ✅ SUCCESS

WARNING: ⚠️

File checker

Item Result Reason
Itzo1978/PEI_Stop/Images/pei_stop.gif ⚠️ WARNING This file is larger than 2 MB!


I am a 🤖, this comment was generated automatically!

Made with ❤️ by the VoronDesign GitHub Team

Copy link
Collaborator

@jontek2 jontek2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@newphreak newphreak merged commit e9ba566 into VoronDesign:main Sep 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants