Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci tests 2 #967

Closed
wants to merge 8 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
98 changes: 57 additions & 41 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,57 +1,73 @@
<!--
Thank you for your interest in contributing to the VoronUsers repository, it is
highly appreciated!
-->

**Please make sure the submission conforms to the rules outlined below. PRs which fail
to conform to the rules below are likely to be rejected.**
<!--
Describe the submission further using the template provided below. The more
details the better! Please don't forget to thoroughly read the mod requirements and rules below
and make sure your mod submission adheres to these rules.
Doing so speeds up the review process and will increase your chances at acceptance.
-->

### Which mods/configurations/profiles are added by this PR?

### How was it tested?

### Any background context you want to provide?

### Screenshots (if appropriate)

### ⚠️⚠️**PLEASE CAREFULLY READ AND APPLY THE RULES BELOW**⚠️⚠️

* [ ] The mod, firmware configuration or slicer profile is in the correct category
folder. Printable mods go to `printer_mods/`, firmware configurations
go to `firmware_configurations/`, slicer profiles go to `slicer_profiles/`.
Create a subfolder with your name, and place the mods in a subfolder with
a descriptive name within that folder, e.g.: `/printer_mods/FHeilmann/flux_capacitor`
a descriptive name within that folder, e.g.: `/printer_mods/FHeilmann/flux_capacitor`.
* [ ] Folder and file naming:
* Folders and filenames shouldn't contain spaces. Only letters `a-zA-Z`, numbers `0-9`, underscores `_`, hyphens `-` and periods `.`
* Primary color: `part_xyz.stl`
* Accent color: `[a]_part_xyz.stl`
* Opaque color (Blocks light): `[o]_part_xyz.stl`
* Clear/transparent color (Allows light): `[c]_part_xyz.stl`
* Quantity, if more than one is needed: `part_xyz_x4.stl`
* Folders and filenames MUST NOT contain spaces. Only letters `a-zA-Z`, numbers `0-9`, underscores `_`, hyphens `-` and periods `.`
* You may use the following filenames to indicate the color and quantity of your prints:
* Primary color: `part_xyz.stl`
* Accent color: `[a]_part_xyz.stl`
* Opaque color (Blocks light): `[o]_part_xyz.stl`
* Clear/transparent color (Allows light): `[c]_part_xyz.stl`
* Quantity, if more than one is needed: `part_xyz_x4.stl`
* [ ] Each mod folder must contain a `.metadata.yml` file with information about the mod.
Refer to the following template for the required and optional contents:
```yaml
---
title: Mod Title # required
description: "This mod does awesome things with awesome printers!" # required
mod_version: 1 # required
printer_compatibility: # required, one or more of the options listed below
- V0
- V1
- V2
- VSW
- Trident
- Legacy
cad: # required: At least 1 CAD file for your mod, path relative to your mod folder
- CAD/my_step_file_1.step
- CAD/my_f360_file_1.f360
images: # optional, image files provided with your mod, path relative to your mod folder
- images/mods_site_card_image.png
- images/side_view.png
- images/install_guide.png
discord_username: discord_person # optional, your discord username
```
* [ ] For each mod, add a small `README.md` file to its folder with a short description
of what the mod accomplishes. This readme can be used to add pictures, give assembly
instructions or specify a bill of materials if the mod requires additional hardware.
* [ ] The PR modifies the top-level `README.md` of the category folder adding the
contribution to the table. Read the top part of the file for instructions on how
to do this. Please preserve the alphabetical ordering while adding new rows. Make sure
to fill out the compatibility matrix to indicate which versions of the Voron printer
the submission is compatible with.
* [ ] The mod/configuration/profile has been tested by the person submitting the mod
and/or other Voron users. Make sure to add information about how the mod was tested below.
* [ ] The mod is not merely a slight modification of an official Voron part, configuration
or profile (i.e. an official Voron part with a few mm added or removed or a slicer profile
which only modifies a few values). *(When in doubt, contact one of the admins in the
* [ ] The mod/configuration/profile has been **TESTED** by the person submitting the mod
and/or other Voron users. Make sure to add information about how the mod was tested below.
* [ ] The mod is **NOT** merely a slight modification of an official Voron part, configuration
or profile (i.e. an official Voron part with a few mm added or removed or a slicer profile
which only modifies a few values). *(When in doubt, contact one of the admins in the
Voron discord before submitting the PR)*
* [ ] Submitted STLs are printable without support. *(If the mod does not meet this criterion
join the Voron discord and ask the other users for advice on how to modify the mod such
that it does not require supports)*
* [ ] Submitted STL files are not corrupt. *(This can be tested by opening the STL in PrusaSlicer
* [ ] Submitted STLs are **printable without support and oriented properly**. If supports can't be avoided,
the model must include break-away supports.
* [ ] Submitted STL files are **not corrupt**. *(This can be tested by opening the STL in PrusaSlicer
and checking if mesh errors are reported.)*
* [ ] Submitted STL files are oriented and scaled properly for printing.
* [ ] Submission includes a CAD file in the form of a `.STEP` or `.SCAD` file
* [ ] Submitted firmware configs or slicer profiles contain no sensitive data (e.g. API keys).

<!--
Describe the submission further using the template provided below. The more
details the better!
-->

#### Which mods/configurations/profiles are added by this PR?

#### How was it tested?

#### Any background context you want to provide?

#### Screenshots (if appropriate)

#### Further notes
* [ ] Submissions **must** include a CAD file in the form of a `.STEP`, `.F360` or `.SCAD` file
* [ ] Submitted firmware configs or slicer profiles **contain no sensitive data** (e.g. API keys).
48 changes: 0 additions & 48 deletions .github/workflows/ci-build.yml

This file was deleted.

70 changes: 70 additions & 0 deletions .github/workflows/pull_request_ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
name: VoronUsers PR CI
run-name: "#${{github.event.number}} - ${{github.event.pull_request.title}}"
on:
pull_request:
types: [opened, reopened, synchronize]

jobs:
checkout_check_whitespace:
permissions:
pull-requests: read
name: Checkout & Check Whitespace
uses: VoronDesign/.github/.github/workflows/pr_checkout_check_whitespace_cache.yml@main
with:
branch: ${{ github.ref }}
cache-key: file-cache-${{github.sha}}
cache-directory: pr-files
setup_python:
name: Prepare python environment
uses: VoronDesign/.github/.github/workflows/prepare-environment.yml@main
with:
apt-packages: "admesh, libadmesh-dev"
pip-packages: "admesh pyyaml imagekitio git+https://github.com/ChristophSchranz/Tweaker-3.git"
python-cache-key: voronusers-python-cache
check_stls:
name: Check STL corruption
needs: [checkout_check_whitespace, setup_python]
uses: VoronDesign/.github/.github/workflows/check-stl-corruption.yml@main
with:
cache-key: file-cache-${{github.sha}}
cache-directory: pr-files
python-cache-key: voronusers-python-cache
check_stl_rotation:
name: Check STL rotation
needs: [checkout_check_whitespace, setup_python]
uses: VoronDesign/.github/.github/workflows/check-stl-rotation.yml@main
secrets:
# ToDo: Change to secrets: inherit once it's in the VoronDesign org
IMAGEKIT_PRIVATE_KEY: ${{ secrets.IMAGEKIT_PRIVATE_KEY }}
IMAGEKIT_PUBLIC_KEY: ${{ secrets.IMAGEKIT_PUBLIC_KEY }}
with:
imagekit-url-endpoint: https://ik.imagekit.io/vorondesign
cache-key: file-cache-${{github.sha}}
cache-directory: pr-files
python-cache-key: voronusers-python-cache
validate_metadata:
name: Check metadata files
needs: [checkout_check_whitespace, setup_python]
uses: VoronDesign/.github/.github/workflows/validate-metadata-files.yml@main
with:
cache-key: file-cache-${{github.sha}}
cache-directory: pr-files
python-cache-key: voronusers-python-cache
preview_readme:
name: Preview README.md
needs: [validate_metadata]
uses: VoronDesign/.github/.github/workflows/preview-readme.yml@main
with:
subdirectory: printer_mods
cache-key: file-cache-${{github.sha}}
cache-directory: pr-files
python-cache-key: voronusers-python-cache
check_files:
name: Check files
needs: [validate_metadata]
uses: VoronDesign/.github/.github/workflows/validate_files.yml@main
with:
subdirectory: printer_mods
cache-key: file-cache-${{github.sha}}
cache-directory: pr-files
python-cache-key: voronusers-python-cache
18 changes: 18 additions & 0 deletions .github/workflows/push_main_ci.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: VoronUsers Push Main CI
on:
push:
branches:
- 'master'
jobs:
preview_readme:
name: Generate README
uses: VoronDesign/.github/.github/workflows/generate-readme.yml@main
with:
subdirectory: printer_mods
commit_msg: "Generate VoronUsers printer_mods README.md [skip ci]"
commit_user: Voron-GitHub-Bot
commit_email: [email protected]
secrets:
VORON_BOT_GITHUB_PAT: ${{ secrets.VORON_BOT_GITHUB_PAT }}


21 changes: 21 additions & 0 deletions printer_mods/1-0-R/handle/.metadata.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
---
title: "V2.4 Handle"
description: "Carrying handle for Voron 2.4 with 6mm clearance for panel clamping"
printer_compatibility:
- V2
images:
- images/handle.jpg
- images/extrusion_with_all_handle_parts.jpg
- images/extrusion_with_handle.jpg
- images/extrusion_with_inner_part_mounted.jpg
- images/extrusion_with_tnuts.jpg
- images/handle_inner_part.jpg
- images/handle_middle_part.jpg
- images/handle_outer_part.jpg
- images/handle_rendering.jpg
- images/inner_part_with_heat_set_inserts.jpg
- images/nuts_and_bolts.jpg
cad:
- CAD/handle.FCStd
- CAD/handle.step
mod_version: 1
13 changes: 13 additions & 0 deletions printer_mods/120decibell/exhaust_housing_side_entry/.metadata.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
title: "Side entry exhaust housing"
description: "Exhaust housing with dual cover screws and single or dual side entry filament paths."
printer_compatibility:
- V2.4
- V1.8
- VT
images:
- images/side_housing_view1.png
- images/side_housing_view2.png
cad:
- CAD/exhaust_housing_side_entry.f3d
mod_version: 1
14 changes: 14 additions & 0 deletions printer_mods/120decibell/huvud_chain_mount/.metadata.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
---
title: "Huvud Chain Mount"
description: "Huvud rear mount for Clockwork or LGX that supports a cable chain."
printer_compatibility:
- V1.8
- VT
images:
- images/huvud_chain_mount.png
- images/huvud_mount_install1.png
- images/huvud_mount_install2.png
cad:
- STEP/huvud_chain_mount_2_hole.step
- STEP/huvud_chain_mount_3_hole.step
mod_version: 2
13 changes: 13 additions & 0 deletions printer_mods/FHeilmann/another_mod/.metadata.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
title: "FHeilmann's other awesome mod"
description: "This mod does other awesome things with awesome printers!"
printer_compatibility:
- V0
- V1
images:
- images/huvud_mount_install2.png
cad:
- STEP/huvud_chain_mount_2_hole.step
discord_username: haribrother
mod_version: 1

18 changes: 18 additions & 0 deletions printer_mods/FHeilmann/bad_mod/.metadata.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
---
title: LOL I'm missing
description: "This mod does awesome things with awesome printers!"
mod_version: 2
printer_compatibility:
- V0
- V1
- V2
- VSW
- Trident
images:
- images/huvud_chain_mount.png
- images/huvud_mount_install1.png
- images/huvud_mount_install2.png
cad:
- STEP/huvud_chain_mount_2_hole.step
- STEP/huvud_chain_mount_3_hole.step
discord_username: haribrother
15 changes: 15 additions & 0 deletions printer_mods/FHeilmann/huvud_chain_mount/.metadata.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
---
title: "FHeilmann's awesome mod"
description: "This mod does awesome things with awesome printers!"
printer_compatibility:
- V1.8
- VT
images:
- images/huvud_chain_mount.png
- images/huvud_mount_install1.png
- images/huvud_mount_install2.png
cad:
- STEP/huvud_chain_mount_2_hole.step
- STEP/huvud_chain_mount_3_hole.step
discord_username: haribrother
mod_version: 2
27 changes: 27 additions & 0 deletions printer_mods/FHeilmann/huvud_chain_mount/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
<h2>Huvud Cable Chain Mount</h2>

A mount for the Huvud toolhead board that mounts on the back for cleaner wiring but still allows for the use of a cable chain. Moves the assembly 6mm up to clear the chain at X0 as it rises onto the X joint. Has space for airflow between the motor and the Huvud to keep temperatures reasonable and includes a wire tie spot for wires coming out of the chain. Current only configured for 3-bolt generic chains. Works for both Clockwork and LGX.

Parts Required:

* (3) M3 heat set inserts for the chain
* (3) M3x6 FHCS to mount the chain
* (2) M3x25 BHCS to mount to the motor
* (4) M3x8 SHCS to mount the Huvud.

Installation:

* Remove the printed support.
* Install the 3 heat set inserts.
* Remove the upper two screws of the motor.
* Install the mount with the two M3x25 BHCS.
* Attach the Huvud with the four M3x8 SHCS. The screws will thread into the plastic. _Be sure to check clearance between electrical components and the M3 BHCS screws underneath_
* Attach the chain with the three M3x6 FHCS.

Designed for the Trident but will also work on a V2.4, just be conscious of clearance to the Z chain.

![](./images/huvud_chain_mount.png)

![](./images/huvud_mount_install1.png)

![](./images/huvud_mount_install2.png) aaa
Loading
Loading