ghost tapping, yes 0 antimash, i checked

source/Postbuild.hx

@@ -29,7 +29,7 @@ class Postbuild
 
       var buildTime:Float = roundToTwoDecimals(end - start);
 
-      trace('Build took: ${buildTime} seconds');
+      haxe.Log.trace('Build took: ${buildTime} seconds', null);
     }
   }
 

source/Prebuild.hx

@@ -12,7 +12,7 @@ class Prebuild
   static function main():Void
   {
     saveBuildTime();
-    trace('Building...');
+    haxe.Log.trace('Building...', null);
   }
 
   static function saveBuildTime():Void

source/funkin/Preferences.hx

@@ -74,6 +74,26 @@ class Preferences
     return value;
   }
 
+  /**
+   * If true, the player will not receive the ghost miss penalty if there are no notes within the hit window.
+   * This is the thing people have been begging for forever lolol.
+   * @default `false`
+   */
+  public static var ghostTapping(get, set):Bool;
+
+  static function get_ghostTapping():Bool
+  {
+    return Save?.instance?.options?.ghostTapping ?? false;
+  }
+
+  static function set_ghostTapping(value:Bool):Bool
+  {
+    var save:Save = Save.instance;
+    save.options.ghostTapping = value;
+    save.flush();
+    return value;
+  }
+
   /**
    * If disabled, flashing lights in the main menu and other areas will be less intense.
    * @default `true`

source/funkin/play/PlayState.hx

@@ -2421,62 +2421,45 @@ class PlayState extends MusicBeatSubState
     for (note in notesInRange)
       notesByDirection[note.direction].push(note);
 
-    while (inputPressQueue.length > 0)
+    while (inputPressQueue.length != 0)
     {
       var input:PreciseInputEvent = inputPressQueue.shift();
 
       playerStrumline.pressKey(input.noteDirection);
 
       var notesInDirection:Array<NoteSprite> = notesByDirection[input.noteDirection];
 
-      if (!Constants.GHOST_TAPPING && notesInDirection.length == 0)
+      if ((!Preferences.ghostTapping || (Preferences.ghostTapping && (holdNotesInRange.length + notesInRange.length != 0)))
+        && notesInDirection.length == 0)
       {
-        // Pressed a wrong key with no notes nearby.
+        // Pressed a wrong key with no notes nearby or pressed a wrong key with no notes nearby AND with notes in a different direction available.
         // Perform a ghost miss (anti-spam).
         ghostNoteMiss(input.noteDirection, notesInRange.length > 0);
 
         // Play the strumline animation.
         playerStrumline.playPress(input.noteDirection);
-        trace('PENALTY Score: ${songScore}');
       }
-      else if (Constants.GHOST_TAPPING && (!playerStrumline.mayGhostTap()) && notesInDirection.length == 0)
-      {
-        // Pressed a wrong key with notes visible on-screen.
-        // Perform a ghost miss (anti-spam).
-        ghostNoteMiss(input.noteDirection, notesInRange.length > 0);
-
-        // Play the strumline animation.
-        playerStrumline.playPress(input.noteDirection);
-        trace('PENALTY Score: ${songScore}');
-      }
-      else if (notesInDirection.length == 0)
-      {
-        // Press a key with no penalty.
-
-        // Play the strumline animation.
-        playerStrumline.playPress(input.noteDirection);
-        trace('NO PENALTY Score: ${songScore}');
-      }
-      else
+      else if (notesInDirection.length != 0)
       {
         // Choose the first note, deprioritizing low priority notes.
         var targetNote:Null<NoteSprite> = notesInDirection.find((note) -> !note.lowPriority);
         if (targetNote == null) targetNote = notesInDirection[0];
         if (targetNote == null) continue;
-
         // Judge and hit the note.
         trace('Hit note! ${targetNote.noteData}');
         goodNoteHit(targetNote, input);
-        trace('Score: ${songScore}');
-
         notesInDirection.remove(targetNote);
-
         // Play the strumline animation.
         playerStrumline.playConfirm(input.noteDirection);
       }
+      else
+      {
+        // Play the strumline animation.
+        playerStrumline.playPress(input.noteDirection);
+      }
     }
 
-    while (inputReleaseQueue.length > 0)
+    while (inputReleaseQueue.length != 0)
     {
       var input:PreciseInputEvent = inputReleaseQueue.shift();
 

source/funkin/save/Save.hx

@@ -92,6 +92,7 @@ class Save
           framerate: 60,
           naughtyness: true,
           downscroll: false,
+          ghostTapping: false,
           flashingLights: true,
           zoomCamera: true,
           debugDisplay: false,
@@ -1074,6 +1075,13 @@ typedef SaveDataOptions =
    */
   var downscroll:Bool;
 
+  /**
+   * If true, the player will not receive the ghost miss penalty if there are no notes within the hit window.
+   * This is the thing people have been begging for forever lolol.
+   * @default `false`
+   */
+  var ghostTapping:Bool;
+
   /**
    * If disabled, flashing lights in the main menu and other areas will be less intense.
    * @default `true`

source/funkin/ui/options/PreferencesMenu.hx

@@ -55,6 +55,9 @@ class PreferencesMenu extends Page
       Preferences.framerate = Std.int(value);
     }, Preferences.framerate, 12, 480, 1, 0);
     #end
+    createPrefItemCheckbox('Ghost Tapping', 'Enable to disable ghost misses', function(value:Bool):Void {
+      Preferences.ghostTapping = value;
+    }, Preferences.ghostTapping);
     createPrefItemCheckbox('Naughtyness', 'Toggle displaying raunchy content', function(value:Bool):Void {
       Preferences.naughtyness = value;
     }, Preferences.naughtyness);

source/funkin/ui/options/items/CheckboxPreferenceItem.hx

@@ -14,7 +14,7 @@ class CheckboxPreferenceItem extends FlxSprite
     animation.addByPrefix('static', 'Check Box unselected', 24, false);
     animation.addByPrefix('checked', 'Check Box selecting animation', 24, false);
 
-    setGraphicSize(Std.int(width * 0.7));
+    setGraphicSize(width * 0.7);
     updateHitbox();
 
     this.currentValue = defaultValue;

source/funkin/util/Constants.hx

@@ -513,7 +513,14 @@ class Constants
    * If true, the player will not receive the ghost miss penalty if there are no notes within the hit window.
    * This is the thing people have been begging for forever lolol.
    */
-  public static final GHOST_TAPPING:Bool = false;
+  @:deprecated("Deprecated! Use Preferences.ghostTapping instead!")
+  public static var GHOST_TAPPING(get, set):Bool;
+
+  @:noCompletion inline static function get_GHOST_TAPPING():Bool
+    return Preferences.ghostTapping;
+
+  @:noCompletion inline static function set_GHOST_TAPPING(value:Bool):Bool
+    return Preferences.ghostTapping = value;
 
   /**
    * The maximum number of previous file paths for the Chart Editor to remember.

source/funkin/util/MathUtil.hx

@@ -22,8 +22,8 @@ class MathUtil
    *
    * @return The interpolated value.
    */
-  @:deprecated('Use smoothLerp instead')
-  public static function coolLerp(base:Float, target:Float, ratio:Float):Float
+  // @:deprecated('Use smoothLerp instead')
+  public static inline function coolLerp(base:Float, target:Float, ratio:Float):Float
   {
     return base + cameraLerp(ratio) * (target - base);
   }
@@ -34,8 +34,8 @@ class MathUtil
    *
    * @return The interpolated value.
    */
-  @:deprecated('Use smoothLerp instead')
-  public static function cameraLerp(lerp:Float):Float
+  // @:deprecated('Use smoothLerp instead')
+  public static inline function cameraLerp(lerp:Float):Float
   {
     return lerp * (FlxG.elapsed / (1 / 60));
   }
@@ -47,7 +47,7 @@ class MathUtil
    * @param target The array or group used in the wrapping procedure.
    * @return The wrapped value.
    */
-  public static function curSelectionWrap(curSelection, increment, target):Int
+  public static inline function curSelectionWrap(curSelection, increment, target):Int
   {
     return FlxMath.wrap(curSelection + increment, 0, target.length - 1);
   }
@@ -58,7 +58,7 @@ class MathUtil
    * @param value The value to get the logarithm of.
    * @return `log_base(value)`
    */
-  public static function logBase(base:Float, value:Float):Float
+  public static inline function logBase(base:Float, value:Float):Float
   {
     return Math.log(value) / Math.log(base);
   }
@@ -108,7 +108,7 @@ class MathUtil
    * @param x value
    * @return `2^x`
    */
-  public static function exp2(x:Float):Float
+  inline public static function exp2(x:Float):Float
   {
     return Math.pow(2, x);
   }
@@ -153,4 +153,10 @@ class MathUtil
 
     return result;
   }
+
+  inline public static function boundInt(value:Int, ?min:Int, ?max:Int):Int
+  {
+    final lowerBound = (min != null && value < min) ? min : value;
+    return (max != null && lowerBound > max) ? max : lowerBound;
+  }
 }