feat: Allow presetDates values to be functions #1037
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Update DatepickerMenu to allow the function presetDate to recibe a
MaybeRefOrGetter<Date[] | string[] | string | Date>
fromPresetDate
.Update the
PresetDate
interface present in interfaces.ts, to use type MaybeRefOrGetter from vueUpdate
package.json
, set peerDependencies to the minimun required vue 3.3.0 (required by MaybeRefOrGetter)Add 2 new tests, fixed 1:
Should preset range from preset-dates
now click on the preset instead of calling its internal functionpresetDate
Should preset range from preset-dates when range its a function
, check when value is a function, it should behave same as beforeShould correctly set today when preset-dates its a function and selected 2 days later
, check that presetDate is executed when pressed, in this case 2 days latter, and returns the correct date, and not the date of when it was mounted.Issue ticket number and link
Solves #1031
Checklist before requesting a review
Dont know how to update the documentation, interface should be updated to the new MaybeRefOrGetter value, and maybe encorage to use functions instead of hard coded values.