Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android): Return response code and body when error on Android #337

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(android): Return response code and body when error on Android #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,8 @@ Event Data
|---|---|---|---|
|`id`|string|Required|The ID of the upload.|
|`error`|string|Required|Error message.|
|`responseCode`|string|Optional|HTTP status code received (Android)|
|`responseBody`|string|Optional|HTTP response body (Android)|

### completed

Expand Down
5 changes: 5 additions & 0 deletions android/src/main/java/com/vydia/RNUploader/GlobalRequestObserverDelegate.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import com.facebook.react.modules.core.DeviceEventManagerModule.RCTDeviceEventEm
import net.gotev.uploadservice.data.UploadInfo
import net.gotev.uploadservice.network.ServerResponse
import net.gotev.uploadservice.observer.request.RequestObserverDelegate
import net.gotev.uploadservice.exceptions.UploadError

class GlobalRequestObserverDelegate(reactContext: ReactApplicationContext) : RequestObserverDelegate {
private val TAG = "UploadReceiver"
Expand All @@ -28,6 +29,10 @@ class GlobalRequestObserverDelegate(reactContext: ReactApplicationContext) : Req
// Make sure we do not try to call getMessage() on a null object
if (exception != null) {
params.putString("error", exception.message)
if (exception is UploadError) {
params.putInt("responseCode", exception.serverResponse.code)
params.putString("responseBody", String(exception.serverResponse.body, Charsets.US_ASCII))
}
} else {
params.putString("error", "Unknown exception")
}
Expand Down
2 changes: 2 additions & 0 deletions index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ declare module "react-native-background-upload" {

export interface ErrorData extends EventData {
error: string
responseCode?: number
responseBody?: string
}

export interface CompletedData extends EventData {
Expand Down