Skip to content

Commit

Permalink
Warn that SENTRY_RELEASE is missing only when BUILD_INFO is missing (#6)
Browse files Browse the repository at this point in the history
When BUILD_INFO is present, we have a valid fallback for SENTRY_RELEASE.
  • Loading branch information
ben-z authored Aug 18, 2024
1 parent 1f5db50 commit c8ce100
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/watcloud_utils/sentry.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def set_up_sentry(
image_rev = build_labels.get("org.opencontainers.image.revision", "unknown_rev")

SENTRY_RELEASE = (
getvar(Vars.SENTRY_RELEASE, logger=logger)
getvar(Vars.SENTRY_RELEASE, warn_if_missing=not BUILD_INFO, logger=logger)
or f"{image_title}:{image_version}@{image_rev}"
)

Expand Down

0 comments on commit c8ce100

Please sign in to comment.