Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Docker image for ARM #201

Merged
merged 3 commits into from
Aug 16, 2024
Merged

Build Docker image for ARM #201

merged 3 commits into from
Aug 16, 2024

Conversation

ben-z
Copy link
Member

@ben-z ben-z commented Aug 7, 2024

This allows us to run this image in our new multi-arch Azure Kubernetes cluster.

Similar to WATonomous/slurm-dist#2 and https://github.com/WATonomous/repo-ingestion/pull/1/files

cc @Jimmyj30

@ben-z
Copy link
Member Author

ben-z commented Aug 7, 2024

@Jimmyj30 can you help me run prettier on this and deploy it? https://github.com/WATonomous/infra-config/pull/2972

@Jimmyj30
Copy link
Contributor

Jimmyj30 commented Aug 7, 2024

@Jimmyj30 can you help me run prettier on this and deploy it? WATonomous/infra-config#2972

Okies, sg

I think this should get deployed on the next run of CI right?

@ben-z
Copy link
Member Author

ben-z commented Aug 7, 2024

I think this should get deployed on the next run of CI right?

We'll want to update the pinned version:
https://github.com/WATonomous/infra-config/blob/6890dba8fd87f38a9d9afd99f89638e0c87638f0/common/kubernetes_images.yml#L9-L10

@Jimmyj30 Jimmyj30 requested review from Jimmyj30 and removed request for Jimmyj30 August 16, 2024 01:58
@Jimmyj30
Copy link
Contributor

@ben-z
just curious, the updated image can be "magically" run on both the amd64 and arm64 platforms right?

@Jimmyj30 Jimmyj30 merged commit a5c0d8c into master Aug 16, 2024
3 checks passed
@ben-z ben-z deleted the ben-z-patch-1 branch August 16, 2024 02:48
@ben-z
Copy link
Member Author

ben-z commented Aug 16, 2024

@ben-z just curious, the updated image can be "magically" run on both the amd64 and arm64 platforms right?

Yea there will be a root manifest that reference both ARM and AMD images. When we pin versions, if we use the checksum of the root manifest instead of the individual image manifests, then the image runner will automatically choose based on the platform.

@ben-z
Copy link
Member Author

ben-z commented Aug 16, 2024

And the root manifest checksum is the one shown on this page I'm pretty sure:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants