Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patchwork Paper implementation using ROS 2. #142

Merged
merged 62 commits into from
Sep 27, 2024
Merged

Patchwork Paper implementation using ROS 2. #142

merged 62 commits into from
Sep 27, 2024

Conversation

akilpath
Copy link
Contributor

@akilpath akilpath commented Aug 13, 2024 •
edited by VishGit1234
Loading

Real-time LiDAR Ground Segmentation using Pathwork (https://github.com/LimHyungTae/patchwork)

akilpath and others added 30 commits June 1, 2024 23:46
@akilpath
Copy transformer samples to occupancy_seg
8b9306a
@akilpath
Copied transformer node layout
72686d7
@akilpath
Renamed files
55f41eb
@VishGit1234
Fix small error
62c7407
@akilpath
Clean up
29ca16c
@VishGit1234
Add pcl package
d021201
@akilpath
Added eigen to dockerifle
3368d02
@VishGit1234
Update docker-compose.world_modeling.yaml
3ccbbfb
@VishGit1234
Update docker-compose.world_modeling.yaml
c98364d
@akilpath
Merge branch 'groundseg-akil' of github.com:WATonomous/wato_monorepo …
54ad82c 
…into groundseg-akil
@akilpath
added tbb to dockerfile
bbd14b9
@akilpath
Started working on it
1db81c7
@akilpath
Finished czm initialization
9d7e706
@akilpath
Plane
67b27d8
@akilpath
Mostly done
23aafe4
@VishGit1234
Add apt update
ed459ae
@akilpath
Fixing small bugs
c67d821
@akilpath
Build / make error with core.cpp
ae006c0
@akilpath
Added main node code, still fails build
206efe3
@akilpath
Commented some things to get it to compile
bdb8e2f
@akilpath
Builds
795bdd9
@akilpath
Foxglove setup plus error debugging
5ed8b81 
exit
exit()
@akilpath
Templated Core file
884156d
@akilpath
lowkey works
34d1641
@akilpath
Added headers to publishers
3f1dadd
@akilpath @VishGit1234
Copy transformer samples to occupancy_seg
6527570
@akilpath @VishGit1234
Copied transformer node layout
cdba3f3
@akilpath @VishGit1234
Renamed files
6605e3f
@VishGit1234
Fix small error
67bda39
@akilpath @VishGit1234
Clean up
45767c8
@VishGit1234 VishGit1234 linked an issue Aug 13, 2024 that may be closed by this pull request
LiDAR Ground Segmentation #122
Closed
@VishGit1234 VishGit1234 added the auto-lint Automatically lints your code (does not commit) label Aug 13, 2024
@github-actions github-actions bot removed the auto-lint Automatically lints your code (does not commit) label Aug 13, 2024
Edwardius
Edwardius reviewed Aug 17, 2024
View reviewed changes
Copy link
Collaborator

@Edwardius Edwardius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, gives me hope that the repo code will be very nice and clean :)

.github/templates/docker_context/docker_context.sh Outdated Show resolved Hide resolved
docker/world_modeling/occupancy_segmentation/occupancy_segmentation.Dockerfile Outdated Show resolved Hide resolved
docker/world_modeling/occupancy_segmentation/occupancy_segmentation.Dockerfile Outdated Show resolved Hide resolved
modules/dev_overrides/docker-compose.world_modeling.yaml Outdated Show resolved Hide resolved
src/world_modeling/occupancy_segmentation/include/occupancy_segmentation_core.hpp Outdated Show resolved Hide resolved
src/world_modeling/occupancy_segmentation/config/params.yaml Outdated Show resolved Hide resolved
src/world_modeling/occupancy_segmentation/package.xml Outdated Show resolved Hide resolved
src/world_modeling/occupancy_segmentation/src/occupancy_segmentation_node.cpp Outdated Show resolved Hide resolved
src/world_modeling/occupancy_segmentation/src/occupancy_segmentation_node.cpp Outdated Show resolved Hide resolved
src/world_modeling/occupancy_segmentation/src/occupancy_segmentation_node.cpp Outdated Show resolved Hide resolved
@Edwardius
Copy link
Collaborator

Address comments and reping me

@VishGit1234 VishGit1234 added auto-lint Automatically lints your code (does not commit) and removed auto-lint Automatically lints your code (does not commit) labels Sep 12, 2024
@VishGit1234 VishGit1234 added the auto-lint Automatically lints your code (does not commit) label Sep 12, 2024
@github-actions github-actions bot removed the auto-lint Automatically lints your code (does not commit) label Sep 12, 2024
@VishGit1234 VishGit1234 added the auto-lint Automatically lints your code (does not commit) label Sep 20, 2024
@github-actions github-actions bot removed the auto-lint Automatically lints your code (does not commit) label Sep 20, 2024
@Edwardius
Copy link
Collaborator

add description of pr and we can merge!

@VishGit1234 VishGit1234 merged commit f121acb into main Sep 27, 2024
26 checks passed
@VishGit1234 VishGit1234 deleted the groundseg-akil branch October 8, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VishGit1234 VishGit1234 VishGit1234 left review comments

@Edwardius Edwardius Edwardius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LiDAR Ground Segmentation
4 participants
@akilpath @Edwardius @VishGit1234 @WATonomousAdmin