Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move common dependencies to qanary_component-parent #368

Merged
merged 6 commits into from
Aug 16, 2024

Conversation

heinpa
Copy link
Collaborator

@heinpa heinpa commented Aug 12, 2024

Resolves
#345
#346

Either remove dependencies entirely from individual POMs, or remove explicit versioning (if handled by DependencyManagement in qanary_component-parent)

@heinpa
Copy link
Collaborator Author

heinpa commented Aug 12, 2024

Qanary-component-QB-Sina was missing a throws declaration for java.net.URISyntaxException on method fetchEntities() that was causing a compilation error during the build process. As far as I can tell, this was not part of the original changes for this PR, and existed independently in the master branch.

UPDATE: The same issue applies to multiple other components.

@heinpa
Copy link
Collaborator Author

heinpa commented Aug 12, 2024

Also, test checkDetectedLanguageForQuestion() for qanary-component-LD-Shuyo tends to fail because of insufficient detection quality, but will succeed when repeated. Maybe this should be re-evaluated in the context of automated testing deployment.

Error:    LanguageDetectionTest.testGermanLanguages:134->checkDetectedLanguageForQuestion:162 Language detection quality not sufficient (83.33333333333334%). From 30 (de) questions only 25 were detected correctly. ==> expected: <true> but was: <false>

@anbo-de
Copy link
Member

anbo-de commented Aug 12, 2024

Also, test checkDetectedLanguageForQuestion() for qanary-component-LD-Shuyo tends to fail because of insufficient detection quality, but will succeed when repeated. Maybe this should be re-evaluated in the context of automated testing deployment.

Error:    LanguageDetectionTest.testGermanLanguages:134->checkDetectedLanguageForQuestion:162 Language detection quality not sufficient (83.33333333333334%). From 30 (de) questions only 25 were detected correctly. ==> expected: <true> but was: <false>

@heinpa Yes, the detection quality should stay constant with the embedded model. Unfortunately, it does not. I suggest reducing the threshold to 80 to overcome this problem hopefully once and for all: https://github.com/WDAqua/Qanary-question-answering-components/blob/master/qanary-component-LD-Shuyo/src/test/java/eu/wdaqua/qanary/component/shuyo/ld/LanguageDetectionTest.java#L28

@heinpa heinpa marked this pull request as ready for review August 16, 2024 10:31
@anbo-de anbo-de merged commit 55170d4 into WDAqua:master Aug 16, 2024
2 checks passed
@anbo-de anbo-de deleted the remove-common-depencies branch August 16, 2024 11:12
@anbo-de
Copy link
Member

anbo-de commented Aug 16, 2024

👍

@anbo-de anbo-de added the enhancement New feature or request label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants