-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move common dependencies to qanary_component-parent #368
Conversation
Qanary-component-QB-Sina was missing a throws declaration for UPDATE: The same issue applies to multiple other components. |
Also, test
|
@heinpa Yes, the detection quality should stay constant with the embedded model. Unfortunately, it does not. I suggest reducing the threshold to 80 to overcome this problem hopefully once and for all: https://github.com/WDAqua/Qanary-question-answering-components/blob/master/qanary-component-LD-Shuyo/src/test/java/eu/wdaqua/qanary/component/shuyo/ld/LanguageDetectionTest.java#L28 |
👍 |
Resolves
#345
#346
Either remove dependencies entirely from individual POMs, or remove explicit versioning (if handled by DependencyManagement in qanary_component-parent)