Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move alerts to left side panel #1333

Merged
merged 15 commits into from
Sep 25, 2024
Merged

Move alerts to left side panel #1333

merged 15 commits into from
Sep 25, 2024

Conversation

ericboucher
Copy link
Collaborator

@ericboucher ericboucher commented Aug 29, 2024

Description

This fixes #1249

How to test the feature:

  • Select the alert icon in the navbar
  • Create an alert

Checklist - did you ...

Test your changes with

  • REACT_APP_COUNTRY=rbd yarn start
  • REACT_APP_COUNTRY=cambodia yarn start
  • REACT_APP_COUNTRY=mozambique yarn start
  • Add / update necessary tests?
  • Add / update outdated documentation?

Screenshot/video of feature:

@ericboucher ericboucher linked an issue Aug 29, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Aug 29, 2024

Build succeeded and deployed at https://prism-1333.surge.sh
(hash 05e7801 deployed at 2024-09-25T14:13:06)

@wadhwamatic
Copy link
Member

Looks good @ericboucher, thanks. A couple of small things:

  1. The create alert button is not readable both when it's inactive and active
  2. Minor / nitpicking - there's a discrepancy in the UI between analysis and alerts selection of a hazard layer

Can't read text on the button:
Screenshot 2024-09-11 at 15 53 25

Alerts vs analysis selection of hazard layer
Screenshot 2024-09-11 at 15 54 25
Screenshot 2024-09-11 at 15 54 18

@ericboucher ericboucher marked this pull request as ready for review September 13, 2024 09:57
@wadhwamatic
Copy link
Member

If I try to create an alert without above / below parameters, I correctly get the message to add them. After adding them, the create alert button never becomes active again blocking me from creating the alert.

Screenshot 2024-09-13 at 14 46 51

@ericboucher ericboucher merged commit 2624eba into master Sep 25, 2024
6 checks passed
@ericboucher ericboucher deleted the alert-ui branch September 25, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Alert module isn't up to date with the new UI
2 participants