Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layer config updates; COUNTRY=jordan #1341

Merged
merged 3 commits into from
Sep 16, 2024
Merged

layer config updates; COUNTRY=jordan #1341

merged 3 commits into from
Sep 16, 2024

Conversation

wadhwamatic
Copy link
Member

@wadhwamatic wadhwamatic commented Sep 12, 2024

Description

This PR reconfigures seasons for CDI layers and adds missing Arabic translations (WIP)

Note that seasons don't work correctly as the current season doesn't have sufficient data. This can be addressed in our temporary date selection hack but it seems we should also better handle the lack of data for the full period without the hack.

How to test the feature:

  • Toggle language to Arabic and confirm translations are accounted for
  • Select seasonal CDI and see that we have two seasons in a year
  • Note that the data lag issue in hip-analysis will cause the initial request to fail. Select a date before 1-May-2024 to see seasonal CDI load correctly

Checklist - did you ...

Test your changes with

  • REACT_APP_COUNTRY=rbd yarn start
  • REACT_APP_COUNTRY=cambodia yarn start
  • REACT_APP_COUNTRY=mozambique yarn start
  • Add / update necessary tests?
  • Add / update outdated documentation?

Screenshot/video of feature:

Copy link

github-actions bot commented Sep 12, 2024

Build succeeded and deployed at https://prism-1341.surge.sh
(hash bbe7e09 deployed at 2024-09-13T22:37:59)

Copy link
Collaborator

@gislawill gislawill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@wadhwamatic wadhwamatic merged commit abe97d0 into master Sep 16, 2024
5 of 6 checks passed
@wadhwamatic wadhwamatic deleted the jor-config-updates branch September 16, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants