Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a table for phase data in tooltips; COUNTRY=cameroon #867

Merged
merged 15 commits into from
Jul 24, 2023
Merged

Add a table for phase data in tooltips; COUNTRY=cameroon #867

merged 15 commits into from
Jul 24, 2023

Conversation

ericboucher
Copy link
Collaborator

@ericboucher ericboucher commented Jun 12, 2023 •
edited
Loading

This fixes issue #794

This PR:

  • updated the size of the tooltip (increased max height) and changed fonts
  • allowed it to be below the point if it fits better on the screen
  • allowed users to hide the data title
  • creates a table view for Phase Classification data
Screenshot 2023-06-12 at 6 15 20 PM Screenshot 2023-07-20 at 5 55 22 PM

@ericboucher ericboucher linked an issue Jun 12, 2023 that may be closed by this pull request
[Feature Request]: Revisit the design of the 'tooltip' and make it more configurable to include more text in an easier to read format #794
Closed
@github-actions
Copy link

github-actions bot commented Jun 12, 2023 •
edited
Loading

Build succeeded and deployed at https://prism-867.surge.sh
(hash 2bcef42 deployed at 2023-07-24T13:22:51)

@wadhwamatic
Copy link
Member

@ericboucher - would Marc have some time to give us some design options? The two current use cases are mentioned in #794. There could be a use case for the decision maker view too.

@ericboucher
Copy link
Collaborator Author

Screenshot 2023-07-14 at 4 07 58 PM

@ericboucher ericboucher changed the title Explore display configuration options for map tooltips; COUNTRY=southsudan Explore display configuration options for map tooltips; COUNTRY=cameroon Jul 14, 2023
@ericboucher ericboucher marked this pull request as ready for review July 20, 2023 15:54
jbperidypathtech
jbperidypathtech approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@jbperidypathtech jbperidypathtech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve because it is ok for me after last comment accounted.

frontend/src/context/layers/admin_level_data.ts Outdated Show resolved Hide resolved
@ericboucher ericboucher changed the title Explore display configuration options for map tooltips; COUNTRY=cameroon Add a table for phase data in tooltips; COUNTRY=cameroon Jul 24, 2023
@ericboucher ericboucher merged commit 5797e92 into master Jul 24, 2023
6 checks passed
@ericboucher ericboucher deleted the tooltip-size branch July 24, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulienPathtech JulienPathtech JulienPathtech left review comments

@jbperidypathtech jbperidypathtech jbperidypathtech approved these changes

@wadhwamatic wadhwamatic Awaiting requested review from wadhwamatic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@ericboucher @wadhwamatic @JulienPathtech @jbperidypathtech