-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start Framework for ExtendableGridsGmshExt #28
Conversation
@jotaraz: Here is a first framework for the gmsh extension. See also https://julialang.org/blog/2023/04/julia-1.9-highlights/#package_extensions I guess you can clone the code and make PRs to the branch |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #28 +/- ##
==========================================
- Coverage 69.96% 69.74% -0.22%
==========================================
Files 24 25 +1
Lines 3602 3844 +242
==========================================
+ Hits 2520 2681 +161
- Misses 1082 1163 +81
☔ View full report in Codecov by Sentry. |
"gmsh_to_extendablegrid.jl" contains the functions to read msh-files and create ExtendableGrids from them (and vice versa). "test_extendablegrid_gmsh.jl" tests those functions using the msh-file "sto3d_pg_0.1.msh"
If you enter the correct paths in the "test_extendablegrid_gmsh.jl" file, you can test the functions from "src/gsmh_to_extendablegrid.jl"
functions to convert ExtendableGrids to msh files and vice versa
Gmsh extension
Thanks @jotaraz for the PR, I sorted the code into the right places and added tests which in the moment fail, there is a bit of work todo for figuring out if two meshs with possibly different point numberings are equal. Will try to fix this today. The main question is how we handle insufficient or missing boundary data. And then there could be a call like In any case I think adding boundary faces is more general than just for gmsh, so it should be in an extra place. |
"gmsh_to_extendablegrid.jl" contains the functions to read msh-files and create ExtendableGrids from them (and vice versa). "test_extendablegrid_gmsh.jl" tests those functions using the msh-file "sto3d_pg_0.1.msh"
If you enter the correct paths in the "test_extendablegrid_gmsh.jl" file, you can test the functions from "src/gsmh_to_extendablegrid.jl"
functions to convert ExtendableGrids to msh files and vice versa
…nto gmsh-extension
Continued in #34 |
No description provided.