Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start Framework for ExtendableGridsGmshExt #28

Closed
wants to merge 33 commits into from
Closed

Conversation

j-fu
Copy link
Member

@j-fu j-fu commented Jun 21, 2023

No description provided.

@j-fu
Copy link
Member Author

j-fu commented Jun 21, 2023

@jotaraz: Here is a first framework for the gmsh extension.

See also https://julialang.org/blog/2023/04/julia-1.9-highlights/#package_extensions

I guess you can clone the code and make PRs to the branch gmsh-extension.

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.22 ⚠️

Comparison is base (596e01f) 69.96% compared to head (e8fd8e1) 69.74%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   69.96%   69.74%   -0.22%     
==========================================
  Files          24       25       +1     
  Lines        3602     3844     +242     
==========================================
+ Hits         2520     2681     +161     
- Misses       1082     1163      +81     
Impacted Files Coverage Δ
ext/ExtendableGridsGmshExt.jl 65.45% <65.45%> (ø)
src/ExtendableGrids.jl 75.00% <66.66%> (-25.00%) ⬇️
src/simplexgrid.jl 96.80% <73.33%> (-0.27%) ⬇️
src/extendablegrid.jl 73.25% <78.57%> (-0.17%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

jotaraz and others added 10 commits June 23, 2023 11:38
"gmsh_to_extendablegrid.jl" contains the functions to read msh-files and create ExtendableGrids from them (and vice versa).
"test_extendablegrid_gmsh.jl" tests those functions using the msh-file "sto3d_pg_0.1.msh"
If you enter the correct paths in the "test_extendablegrid_gmsh.jl" file, you can test the functions from "src/gsmh_to_extendablegrid.jl"
functions to convert ExtendableGrids to msh files and vice versa
@j-fu
Copy link
Member Author

j-fu commented Jun 30, 2023

@jotaraz, @chmerdon

Thanks @jotaraz for the PR, I sorted the code into the right places and added tests which in the moment fail, there is a bit of work todo for figuring out if two meshs with possibly different point numberings are equal.

Will try to fix this today.

The main question is how we handle insufficient or missing boundary data.
I think we should be able to cover the case where they are missing throughout the software stack. This is no first priority, so IMHO the first version of this could be to add one dummy bface...

And then there could be a call like seal!(grid) which adds all missing outer boundary faces to a grid, may be with some coordinate depending semantics on region numbers.

In any case I think adding boundary faces is more general than just for gmsh, so it should be in an extra place.

@j-fu j-fu changed the title Start Framework for SimplexGridGmshExt Start Framework for ExtendableGridsGmshExt Jul 1, 2023
j-fu and others added 11 commits July 3, 2023 10:15
"gmsh_to_extendablegrid.jl" contains the functions to read msh-files and create ExtendableGrids from them (and vice versa).
"test_extendablegrid_gmsh.jl" tests those functions using the msh-file "sto3d_pg_0.1.msh"
If you enter the correct paths in the "test_extendablegrid_gmsh.jl" file, you can test the functions from "src/gsmh_to_extendablegrid.jl"
functions to convert ExtendableGrids to msh files and vice versa
@j-fu
Copy link
Member Author

j-fu commented Nov 23, 2023

Continued in #34

@j-fu j-fu closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants