Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for subgrid in case there is empty boundary data #36

Merged
merged 2 commits into from
Jan 19, 2024
Merged

fix for subgrid in case there is empty boundary data #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d49f4c1
fix for subgrid in case there is empty boundary data in the parent gr…
chmerdon Jan 17, 2024
2c1e5f4
modified the subgrid+extrusion test a bit to test if a subgrid for a …
chmerdon Jan 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/subgrid.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,13 @@ function subgrid(parent,

subgrid[BFaceRegions]=sub_bfaceregions
subgrid[BFaceGeometries]=sub_bfacetypes
subgrid[BFaceNodes]=tryfix(sub_bfacenodes)
subgrid[NumBFaceRegions]=maximum(sub_bfaceregions)
if length(sub_bfaceregions) > 1
subgrid[BFaceNodes]=tryfix(sub_bfacenodes)
subgrid[NumBFaceRegions]=maximum(sub_bfaceregions)
else
subgrid[BFaceNodes]=zeros(Ti, 2, 0)
subgrid[NumBFaceRegions]=0
end
end
subgrid[CoordinateSystem]=parent[CoordinateSystem]

Expand Down
8 changes: 6 additions & 2 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ end
end

@testset "subgrid+extrusion" begin
function subgen(; h = 0.2)
function subgen(; region = 1, h = 0.2)
X = collect(-1:h:2)
Y = collect(0:h:1)
Z = collect(0:h:2)
Expand All @@ -158,15 +158,19 @@ end
# Mark cut-out regions as 2
cellmask!(g, [-1, 0, 0], [0, 1, 1], 2)
cellmask!(g, [1, 0, 0], [2, 1, 1], 2)
# Mark interior region 3 with region 2
cellmask!(g, [-0.75,0.25,0.25], [-0.25,0.75,0.75], 3)

# add new interface elements
bfacemask!(g, [-1, 0, 1], [2, 1, 1], 3; allow_new = true)
bfacemask!(g, [0, 0, 0], [0, 1, 1], 3; allow_new = true)
bfacemask!(g, [1, 0, 0], [1, 1, 1], 3; allow_new = true)

# return subgrid of region 1
subgrid(g, [1])
subgrid(g, [region])
end
sub2 = subgen(; region = 3)

@test numbers_match(subgen(), 756, 3000, 950)

X = collect(0:0.25:1)
Expand Down
Loading