Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstantiation of CellVolumes, FaceNormals etc. #41

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Reinstantiation of CellVolumes, FaceNormals etc. #41

merged 1 commit into from
Mar 21, 2024

Conversation

chmerdon
Copy link
Member

  • added update! function to trigger reinstationation of cell components
  • CellVolumes, FaceVolumes etc. and FaceNormals and EdgeTangents now keep existing arrays

Example:
update!(grid, CellVolumes)
checks if CellVolumes exists and only then triggers instantiate(grid, CellVolumes) which then keeps the existing array and just updates the values

…antiate of Volumes components and FaceNormals and EdgeTangents keep existing arrays.
@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 73.63%. Comparing base (06a2f11) to head (edc1f93).
Report is 7 commits behind head on master.

Files Patch % Lines
src/derived.jl 36.36% 7 Missing ⚠️
src/extendablegrid.jl 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   73.01%   73.63%   +0.62%     
==========================================
  Files          27       27              
  Lines        4239     4244       +5     
==========================================
+ Hits         3095     3125      +30     
+ Misses       1144     1119      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chmerdon chmerdon changed the title Reinstationation of CellVolumes, FaceNormals etc. Reinstantiation of CellVolumes, FaceNormals etc. Mar 19, 2024
@j-fu j-fu merged commit 47ce01f into WIAS-PDELib:master Mar 21, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants