Skip to content

Commit

Permalink
Bugfix: in makie.jl state tuple update sometimes didn't take into acc…
Browse files Browse the repository at this point in the history
…ount grids, parent and funcs
  • Loading branch information
j-fu committed Apr 6, 2023
1 parent 5d52036 commit a040fd1
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "GridVisualize"
uuid = "5eed8a63-0fb0-45eb-886d-8d5a387d12b8"
authors = ["Juergen Fuhrmann <[email protected]>"]
version = "1.0.2"
version = "1.0.3"

[deps]
ColorSchemes = "35d6a980-a343-548e-a6ea-1d62b119f2f4"
Expand Down
10 changes: 6 additions & 4 deletions src/makie.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1262,8 +1262,9 @@ function scalarplot!(ctx, TP::Type{MakieType}, ::Type{Val{3}}, grids, parentgrid
end
# adjust_planes()
ctx[:data][] = (
g = grid,
f = func,
g = grids,
p = parentgrid,
f = funcs,
x = ctx[:xplanes],
y = ctx[:yplanes],
z = ctx[:zplanes],
Expand All @@ -1275,8 +1276,9 @@ function scalarplot!(ctx, TP::Type{MakieType}, ::Type{Val{3}}, grids, parentgrid
add_scene!(ctx, makescene3d(ctx))
else
ctx[:data][] = (
g = grid,
f = func,
g = grids,
p = parentgrid,
f = funcs,
x = ctx[:xplanes],
y = ctx[:yplanes],
z = ctx[:zplanes],
Expand Down

2 comments on commit a040fd1

@j-fu
Copy link
Member Author

@j-fu j-fu commented on a040fd1 Apr 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/81184

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.0.3 -m "<description of version>" a040fd15b06df949f9a5dd6b9190535c113797b5
git push origin v1.0.3

Please sign in to comment.