-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: use custom MathJax package and config to display \longrightleftharpoons correctly #115
Conversation
…arpoons correctly
I believe there are several ways to extract the A straightfoward way to extract this URL from the But since this is not an issue specific to I already hacked together an example solution that could later be incorporated into |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #115 +/- ##
==========================================
- Coverage 85.33% 80.98% -4.36%
==========================================
Files 24 24
Lines 2803 2913 +110
==========================================
- Hits 2392 2359 -33
- Misses 411 554 +143 ☔ View full report in Codecov by Sentry. |
Checked locally - this works, great, thanks @pjaap . @Da-Be-Ru : I think the PR is good enough in the moment. ExampleJuggler has two ways of making Pluto notebooks accessible in the docs: rendered by Pluto itself in an iframe (using PlutoSliderServer.jl) or as plain HTML via PlutoStaticHTML.jl. |
We now use Catalyst.jl v14 im runtests which requires Julia 1.10 (soon the new LTS). The SciML ecosystem is already mostly on 1.10.
Maybe, but I think with hard-coded URLs, this current version could just lead to similar errors depending on whatever version of I tried my hand at a rough demonstration of what I mean on this fork which seems to work for me with both |
Ok, we should keep this as is now and wait for JuliaDocs/Documenter.jl#2549 |
JuliaDocs/Documenter.jl#2549 looks like a better solution than what we did downstream here. |
Just added this to the Documenter PR... |
In a discussion with @Da-Be-Ru @jpthiele we developed a hack to display the broken math symbols in the current doc in https://j-fu.github.io/VoronoiFVM.jl/dev/plutostatichtml_examples/heterogeneous-catalysis/
Pluto.jl
uses a differentMathJax
thanDocumenter.jl
.Especially, we need the LaTeX package
mhchem
.The solution is not intended to be final. A good solution would require to extract the
MathJax
package fromPluto.jl
and pass this to theMathJax3
call as aurl
keyword.