Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove aggregation key identifier size limit for trigger registrations #1435

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Remove aggregation key identifier size limit for trigger registrations #1435

merged 2 commits into from
Sep 17, 2024

Conversation

linnan-github
Copy link
Collaborator

@linnan-github linnan-github commented Sep 17, 2024 •
edited by pr-preview bot
Loading

Fixes #1434

Preview | Diff

@giladbarkan-github
Copy link
Collaborator

Is there any associated JavaScript that would need to be updated?

@linnan-github
Copy link
Collaborator Author

linnan-github commented Sep 17, 2024 •
edited
Loading

Is there any associated JavaScript that would need to be updated?

Thanks. Updated the header validator as well.

@linnan-github linnan-github merged commit 3165ffc into WICG:main Sep 17, 2024
3 checks passed
@linnan-github linnan-github deleted the removeKeyLimitTrigger branch September 17, 2024 17:04
aarongable pushed a commit to chromium/chromium that referenced this pull request Sep 17, 2024
@linnan-github
Remove aggregation key identifier size limit for trigger registrations
3f65fe7 
WICG/attribution-reporting-api#1435

Change-Id: Ic4bc2fa23235454fce300c2af265f6a2e39b4dac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5870543
Reviewed-by: Andrew Paseltiner <[email protected]>
Reviewed-by: danakj <[email protected]>
Commit-Queue: Nan Lin <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1356622}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giladbarkan-github giladbarkan-github giladbarkan-github approved these changes

@apasel422 apasel422 apasel422 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider removing the aggregation key identifier length limit on trigger registrations
3 participants
@linnan-github @giladbarkan-github @apasel422