Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up epsilonToBoundInfoGainAndDp #1436

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Clean up epsilonToBoundInfoGainAndDp #1436

merged 1 commit into from
Sep 17, 2024

Conversation

apasel422
Copy link
Collaborator

@apasel422 apasel422 commented Sep 17, 2024 •
edited
Loading

  • Avoid unnecessary bit operations resulting in bigint construction
  • Avoid unnecessary array construction in tests

@apasel422
Clean up epsilonToBoundInfoGainAndDp
85bfd9c 
- Avoid unnecessary bit operations
- Avoid unnecessary array construction in tests
@apasel422 apasel422 marked this pull request as ready for review September 17, 2024 17:07
giladbarkan-github
giladbarkan-github approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@giladbarkan-github giladbarkan-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@apasel422 apasel422 merged commit 2877fda into WICG:main Sep 17, 2024
2 checks passed
@apasel422 apasel422 deleted the tidy branch September 17, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giladbarkan-github giladbarkan-github giladbarkan-github approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@apasel422 @giladbarkan-github