Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explainer change for separate rate-limits for embedded site #1457

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions EVENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -980,6 +980,11 @@ were reported.

In order to achieve the privacy goals listed above the API has various rate limits, which can be found [here](https://github.com/WICG/attribution-reporting-api/blob/main/params/chromium-params.md) for Chromium.

Note: Browsers may choose to allow separate limits, e.g. storage limit,
rate-limits, and destination limits, for the embedded site/origin for specific
use cases (for example, [AMP](https://amp.dev) pages rendered by an AMP
cache/viewer provider).

### Trigger Data

Trigger data, e.g. advertiser-side data, is extremely important for critical use
Expand Down
10 changes: 8 additions & 2 deletions index.bs
Original file line number Diff line number Diff line change
Expand Up @@ -1869,8 +1869,14 @@ To <dfn>check if cookie-based debugging is allowed</dfn> given a

<h3 algorithm id="obtaining-context-origin">Obtaining context origin</h3>

To obtain the <dfn export for=node>context origin</dfn> of a [=node=] |node|, return |node|'s [=node navigable=]'s
[=navigable/top-level traversable=]'s [=navigable/active document=]'s [=origin=].
To obtain the <dfn export for=node>context origin</dfn> of a [=node=] |node|:

1. Optionally, return the embedded origin if it exists.
1. Return |node|'s [=node navigable=]'s [=navigable/top-level traversable=]'s
[=navigable/active document=]'s [=origin=].

Note: The user agent MAY return the embedded origin to allow separate limits
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: replace capital MAY

for specific use cases.

<h3 id="obtaining-randomized-response">Obtaining a randomized response</h3>

Expand Down
4 changes: 2 additions & 2 deletions verbose_debugging_reports.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ The `body` will contain the following fields for all source debugging reports:
This will be a string if there was one such site, or a list of strings if
there were multiple.
* `source_event_id`: The source registration's `source_event_id`.
* `source_site`: The top-level site on which the source registration occurred.
* `source_site`: The top-level site, or the embedded site for specific use cases, on which the source registration occurred.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add (for example, AMP pages rendered by an AMP
cache/viewer provider) here as well


Additionally:

Expand Down Expand Up @@ -149,7 +149,7 @@ Additionally:
* If the trigger was attributed to a source, then the `body` will also contain
the following fields:
* `source_event_id`: The source registration's `source_event_id`.
* `source_site`: The top-level site on which the source registration
* `source_site`: The top-level site, or the embedded site for specific use cases, on which the source registration
occurred.
* `source_debug_key`: The source registration's `debug_key`, but omitted if
the source registration did not contain a valid `debug_key` or
Expand Down
Loading