Clarify that <script type=webbundle> doesn't fire a load nor an error event #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irori
reviewed
Oct 26, 2021
explainers/subresource-loading.md
Outdated
| @@ -172,6 +172,11 @@ using document's [base URL](https://html.spec.whatwg.org/#document-base-url). | |||
|
|
|||
| `<script type="webbundle">` doesn't support `src=` attribute. The rule must be inline. | |||
|
|
|||
| `<script type="webbundle">` doesn't fire a `load` event. | |||
There was a problem hiding this comment.
Done. Mentioned it.
Yes, this is pretty inconvenient. For further discussion, I've filed an issue #697. I've also updated the PR to mention an error event and the issue #697. This PR can be now considered to clarify the current support status. |
hayatoito
changed the title
irori
approved these changes
Oct 26, 2021
github-actions bot
added a commit
that referenced
this pull request
Oct 26, 2021
… event (#696) SHA: 4096cd0 Reason: push, by @hayatoito Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
hayatoito
added a commit
to hayatoito/webpackage
that referenced
this pull request
Oct 26, 2021
hayatoito
added a commit
that referenced
this pull request
Oct 26, 2021
github-actions bot
added a commit
that referenced
this pull request
Oct 26, 2021
SHA: 658b98f Reason: push, by @hayatoito Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #670.