Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fetch monkeypatches to subresource-loading spec #708 #715

Merged
merged 6 commits into from
Mar 7, 2022

Conversation

hayatoito
Copy link
Collaborator

@hayatoito hayatoito commented Mar 3, 2022

This is a starting point of writing "fetch monkeypatches".

There are still many TODOs remaining, but we can refine iteratively.


Preview | Diff

This is a starting point of writing "fetch monkeypatches".

There are still many TODOs remaining, but we can refine iteratively.
@hayatoito hayatoito requested a review from irori March 3, 2022 05:46
@hayatoito
Copy link
Collaborator Author

cc: @hiroshige-g.
Can we add you to this repository's member so that we can add you to a reviewer?

subresource-loading.bs Outdated Show resolved Hide resolved
subresource-loading.bs Outdated Show resolved Hide resolved
subresource-loading.bs Outdated Show resolved Hide resolved
subresource-loading.bs Outdated Show resolved Hide resolved
subresource-loading.bs Outdated Show resolved Hide resolved
- Introduce Algorithms section
- Introduce subsection for each algorithm
@hayatoito
Copy link
Collaborator Author

Thanks for the review. I restructured sections. Now it became much better.

@hayatoito
Copy link
Collaborator Author

hayatoito commented Mar 3, 2022

cc: @jyasskin just in case.
We try to have monkeypatches in this repository, instead of make a PR for upstream standard (Fetch or HTML), as the 1st step to have a spec. If you have any advice, we appreciate it!

@hayatoito
Copy link
Collaborator Author

cc: @yoavweiss just in case too.

We are trying to have a spec for Subresource Loading with Web Bundles before sending "Intent to Ship".

#708

subresource-loading.bs Outdated Show resolved Hide resolved
subresource-loading.bs Show resolved Hide resolved
subresource-loading.bs Outdated Show resolved Hide resolved
subresource-loading.bs Outdated Show resolved Hide resolved
subresource-loading.bs Outdated Show resolved Hide resolved
subresource-loading.bs Outdated Show resolved Hide resolved
Format the file, using 2 indent so that we can mechanicaly format this file.

We can format this file with `prettier`.

Example:

$ cat subresource-loadinge.md | prettier --prose-wrap=always \
--stdin-filepath "dummy.md"

This change also contains minor editorial changes.
@hayatoito
Copy link
Collaborator Author

Thanks for the review. Could you please take a look again?
This file is now mechanically formatted with prettier.

subresource-loading.bs Outdated Show resolved Hide resolved
subresource-loading.bs Outdated Show resolved Hide resolved
@hayatoito
Copy link
Collaborator Author

Thanks for the review. PTAL.

Copy link
Collaborator

@irori irori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment

subresource-loading.bs Outdated Show resolved Hide resolved
@hayatoito
Copy link
Collaborator Author

Thanks for the review! Let me merge this PR.

@hayatoito hayatoito merged commit aef4300 into WICG:main Mar 7, 2022
github-actions bot added a commit that referenced this pull request Mar 7, 2022
SHA: aef4300
Reason: push, by @hayatoito

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Apr 1, 2022
SHA: aef4300
Reason: push, by @hayatoito

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants