Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipdeptree to In-Dockerfile Dependency Generation #44

Merged
merged 23 commits into from
Oct 13, 2023
Merged

Conversation

ric-evans
Copy link
Member

Also, don't install/use podman if it's not needed.

tested on WIPACrepo/SkyDriver#80 & icecube/skymap_scanner#226

@ric-evans ric-evans added the enhancement New feature or request label Oct 13, 2023
@ric-evans ric-evans self-assigned this Oct 13, 2023
@ric-evans ric-evans requested a review from dsschult October 13, 2023 19:18
Copy link
Contributor

@dsschult dsschult left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Probably a useful tool.

I guess the question is, why only run it in the Dockerfile, and not on regular python libs?

@ric-evans
Copy link
Member Author

Interesting. Probably a useful tool.

I guess the question is, why only run it in the Dockerfile, and not on regular python libs?

pip-compile already has a dependency tree, albeit not as detailed as this one. pip-compile also doesn't require the package to be installed. There is https://github.com/ddelange/pipgrip, which does not require installs. However, it's only in v0.10.7.

@ric-evans ric-evans merged commit 8a117ba into main Oct 13, 2023
3 checks passed
@ric-evans ric-evans deleted the pipdeptree branch October 13, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants