Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #233

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Fix tests #233

merged 3 commits into from
Apr 12, 2024

Conversation

AntObi
Copy link
Collaborator

@AntObi AntObi commented Apr 12, 2024

Fix failing CI

Description

  • Fix pymatgen requirement in setup.py
  • Add python 3.12 to CI to check for compatability

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Pytest tests still pass locally

Test Configuration:

  • Python version: 3.10.
  • Operating System: Ubuntu 20.04

Reviewers

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.37%. Comparing base (b1fd360) to head (f5b2a66).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
+ Coverage   73.27%   73.37%   +0.10%     
==========================================
  Files          24       24              
  Lines        1998     1998              
==========================================
+ Hits         1464     1466       +2     
+ Misses        534      532       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AntObi AntObi merged commit 022eb50 into master Apr 12, 2024
19 checks passed
@AntObi AntObi deleted the fix-tests branch April 12, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant