Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in a threshold to eliminate species pairs not present in the lambda table #249

Merged
merged 1 commit into from
May 24, 2024

Conversation

AntObi
Copy link
Collaborator

@AntObi AntObi commented May 24, 2024

Description

This PR fixes the issue with Doper where if two species are not observed to have a similarity indices, then they are assigned a default probability by the underlying CationMutator instance. This results in doping suggestions which are likely to be unfeasible. The fix works by getting that threshold probability value and eliminating possible dopant predictions below that threshold.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Reviewers

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.36%. Comparing base (2e2c720) to head (1971ac5).
Report is 115 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
+ Coverage   73.29%   73.36%   +0.06%     
==========================================
  Files          24       24              
  Lines        1996     2001       +5     
==========================================
+ Hits         1463     1468       +5     
  Misses        533      533              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AntObi AntObi merged commit c54fba2 into WMD-group:master May 24, 2024
16 checks passed
@AntObi AntObi deleted the doper_fix branch May 24, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant