Add in a threshold to eliminate species pairs not present in the lambda table #249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue with
Doper
where if two species are not observed to have a similarity indices, then they are assigned a default probability by the underlyingCationMutator
instance. This results in doping suggestions which are likely to be unfeasible. The fix works by getting that threshold probability value and eliminating possible dopant predictions below that threshold.Type of change
Reviewers
N/A
Checklist: