Revert "Include SkipSpecies cosine similarities in package files" #262
Conversation
WalkthroughThe recent changes involve updating the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #262 +/- ##
========================================
Coverage 74.50% 74.50%
========================================
Files 24 24
Lines 2083 2083
========================================
Hits 1552 1552
Misses 531 531 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
setup.py (1)
Line range hint
14-14: Remove unused imports to clean up the code.- import unittest - from setuptools import ExtensionAlso applies to: 16-16
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- MANIFEST.in (1 hunks)
- examples/Dopant_Prediction/doper_example.ipynb (6 hunks)
- setup.py (1 hunks)
Files not summarized due to errors (1)
- examples/Dopant_Prediction/doper_example.ipynb: Error: Message exceeds token limit
Files skipped from review due to trivial changes (1)
- MANIFEST.in
Additional context used
Ruff
setup.py
14-14:
unittestimported but unused (F401)
16-16:
setuptools.Extensionimported but unused (F401)
Additional comments not posted (3)
setup.py (1)
39-48: The changes topackage_dataprovide a more controlled inclusion of files in the package. Ensure all necessary file types are listed.Verification successful
The
smact/datadirectory contains files with extensions.csv,.txt,.data,.xlsx, and.json, which are all included in thepackage_datadictionary. No additional file types are necessary.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that all necessary file types are included in the package data. # Test: List all file types in the smact/data directory. Expect: Only listed types should be present. fd --type file --extension txt,csv,data,xlsx,json 'smact/data'Length of output: 408
Script:
#!/bin/bash # Description: Verify that all necessary file types are included in the package data. # Test: List all file types in the smact/data directory. Expect: Only listed types should be present. fd --type file --full-path 'smact/data' --extension txt,csv,data,xlsx,jsonLength of output: 74
Script:
#!/bin/bash # Description: List all files in the smact/data directory to verify its contents. # Test: List all files in the smact/data directory. fd --type file --full-path 'smact/data'Length of output: 742
examples/Dopant_Prediction/doper_example.ipynb (2)
36-36: Ensure the installation command is executed only in the Colab environment. This is a good practice to prevent unnecessary installations.Also applies to: 40-40, 43-43
47-50: Verify the execution of dopant prediction functions to ensure they work as expected.Also applies to: 78-81, 103-109, 125-128, 149-154, 159-166
Reverts #261
Summary by CodeRabbit