Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed capability typos preventing regenration and delete #63

Closed
wants to merge 1 commit into from

Conversation

szczys
Copy link

@szczys szczys commented Jun 5, 2020

This addresses #62

@TimothyBJacobs
Copy link
Member

Thanks for the PR @szczys! This isn't correct though. delete_post, edit_post, edit_user etc... are all valid meta capability checks. AFAIK the issue in #62 is because those meta capability checks aren't being mapped due to how the post type is being registered.

@szczys
Copy link
Author

szczys commented Jun 5, 2020

Thanks for the info. I'll look into it and see if I can figure out where my install is going wrong with that mapping.

@szczys szczys closed this Jun 5, 2020
@TimothyBJacobs
Copy link
Member

To clarify, this isn't a problem specific to your install. It is an issue with the plugin, I'm just not 100% sure what the right fix it.

@szczys
Copy link
Author

szczys commented Jun 5, 2020

I had certainly noticed some problems here as another plugin that i have installed is throwing warning when parsing these entries:

Notice: Trying to get property 'ID' of non-object in /srv/www/wordpress-one/public_html/wp-content/plugins/edit-flow/modules/custom-status/custom-status.php on line 739

Notice: Trying to get property 'label' of non-object in /srv/www/wordpress-one/public_html/wp-content/plugins/edit-flow/modules/custom-status/custom-status.php on line 741

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants