Skip to content

Commit

Permalink
fix: remove useless alwaysVisible on dropdownMenu (#2280)
Browse files Browse the repository at this point in the history
  • Loading branch information
theo-mesnil authored Sep 20, 2023
1 parent e24c48b commit 8538fec
Showing 1 changed file with 12 additions and 16 deletions.
28 changes: 12 additions & 16 deletions packages/DropdownMenu/src/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ const DropdownMenuComponent = forwardRef<'div', DropdownMenuProps>(
({ children, dataTestId, innerProps = {}, store, gutter = 'xs', ...rest }, ref) => {
const theme = useTheme()
const arrowElement = store.useState('arrowElement')
const isOpen = store.useState('open')

let parsedGutter = gutter
if (typeof parsedGutter === 'string') {
Expand All @@ -36,21 +35,18 @@ const DropdownMenuComponent = forwardRef<'div', DropdownMenuProps>(
}

return (
isOpen && (
<Ariakit.Menu
alwaysVisible
aria-label="dropdown-menu"
data-testid={dataTestId}
gutter={parsedGutter}
ref={ref}
render={<S.Inner {...innerProps} />}
store={store}
tabIndex={0}
{...rest}
>
{children}
</Ariakit.Menu>
)
<Ariakit.Menu
aria-label="dropdown-menu"
data-testid={dataTestId}
gutter={parsedGutter}
ref={ref}
render={<S.Inner {...innerProps} />}
store={store}
tabIndex={0}
{...rest}
>
{children}
</Ariakit.Menu>
)
}
)
Expand Down

0 comments on commit 8538fec

Please sign in to comment.