-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use theme spaces for DropdownMenu gutter #2205
Use theme spaces for DropdownMenu gutter #2205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't want to add another value from theme, 10px is the spacing from the specs by default and we need all to use it to be consistent
@Calvein but i think we need to get default space from theme and not with a number |
@Calvein i check the figma and it's now |
5155dbd
to
49917ab
Compare
@Calvein need rebase :) |
4b06a1c
to
1815627
Compare
All good 🚀 |
Rather than forcing the user to set a number for the number, I've added the spaces coming from the theme in addition.
@Jademhm & @aurelienalletru we have a spacing (the gutter) of 10 between the trigger & the dropdown by default, would you rather have 8 (sm) or 12 (md)?