Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use theme spaces for DropdownMenu gutter #2205

Merged
merged 5 commits into from
Sep 13, 2023

Conversation

Calvein
Copy link
Contributor

@Calvein Calvein commented Aug 21, 2023

Rather than forcing the user to set a number for the number, I've added the spaces coming from the theme in addition.

image

@Jademhm & @aurelienalletru we have a spacing (the gutter) of 10 between the trigger & the dropdown by default, would you rather have 8 (sm) or 12 (md)?

@Calvein Calvein requested review from a team as code owners August 21, 2023 15:48
@github-actions
Copy link

👀 Visit Preview

Copy link
Contributor

@theo-mesnil theo-mesnil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't want to add another value from theme, 10px is the spacing from the specs by default and we need all to use it to be consistent

@theo-mesnil
Copy link
Contributor

@Calvein but i think we need to get default space from theme and not with a number

@Calvein
Copy link
Contributor Author

Calvein commented Aug 22, 2023

@Calvein but i think we need to get default space from theme and not with a number

That was a suggestion but I didn't look at the specs about the 10px, I thought it was an old value that we kept 👀

I've added the gutter to the theme and I added it as a default in fd3e382

@theo-mesnil
Copy link
Contributor

Capture d’écran 2023-08-22 à 14 30 07

@Calvein i check the figma and it's now xs

@Calvein Calvein force-pushed the refactor-use-wui-theme-gutter-dropdown-menu branch from 5155dbd to 49917ab Compare August 22, 2023 13:32
@theo-mesnil
Copy link
Contributor

@Calvein need rebase :)

@Calvein Calvein force-pushed the refactor-use-wui-theme-gutter-dropdown-menu branch from 4b06a1c to 1815627 Compare September 13, 2023 08:11
@Calvein
Copy link
Contributor Author

Calvein commented Sep 13, 2023

All good 🚀

@theo-mesnil theo-mesnil merged commit 6e666ac into master Sep 13, 2023
11 checks passed
@theo-mesnil theo-mesnil deleted the refactor-use-wui-theme-gutter-dropdown-menu branch September 13, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants