Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(slider): connect input and slider position, disabled input, values style #2219

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Fix(slider): connect input and slider position, disabled input, values style #2219

merged 4 commits into from
Sep 13, 2023

Conversation

RobelTekle
Copy link
Contributor

@RobelTekle RobelTekle commented Aug 29, 2023 •
edited
Loading

FIX :

  • disabled props should disable the number inputs too
  • onBlur after changing the number input value should update the slider position
  • fix values labels position in Slider component
  • ensure the respect of min and max when user update value using arrow keys
  • fix yellow range position and length in Slider.Range when min and max are set and different from 0 and 100

fixes #2168

Before

Enregistrement.de.l.ecran.2023-08-30.a.10.00.43.mov

After

Enregistrement.de.l.ecran.2023-08-30.a.10.10.58.mov

@RobelTekle RobelTekle added the bug Something isn't working label Aug 29, 2023
@github-actions
Copy link

👀 Visit Preview

@github-actions github-actions bot added the wip label Aug 29, 2023
@RobelTekle RobelTekle force-pushed the fix-slider-input-connection-2168 branch 2 times, most recently from e8b930e to b318028 Compare August 30, 2023 08:26
@RobelTekle RobelTekle marked this pull request as ready for review August 30, 2023 08:32
@RobelTekle RobelTekle requested a review from a team as a code owner August 30, 2023 08:32
@github-actions github-actions bot added to-review and removed wip labels Aug 30, 2023
@RobelTekle RobelTekle force-pushed the fix-slider-input-connection-2168 branch from b318028 to 9fdb64f Compare August 30, 2023 08:35
theo-mesnil
theo-mesnil reviewed Aug 30, 2023
View reviewed changes
Copy link
Contributor

@theo-mesnil theo-mesnil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for disabled input :)

@RobelTekle RobelTekle force-pushed the fix-slider-input-connection-2168 branch from 9fdb64f to 5f1af37 Compare August 31, 2023 13:22
@theo-mesnil theo-mesnil changed the title Fix Slider: connect input and slider position, disabled input, values style Fix(slider): connect input and slider position, disabled input, values style Sep 7, 2023
@theo-mesnil theo-mesnil merged commit 5fa1cea into master Sep 13, 2023
2 checks passed
@theo-mesnil theo-mesnil deleted the fix-slider-input-connection-2168 branch September 13, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theo-mesnil theo-mesnil theo-mesnil approved these changes

@Leiksa Leiksa Awaiting requested review from Leiksa

Assignees
No one assigned
Labels
approved bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Slider Component: input number and slider bar are disconnected
2 participants
@RobelTekle @theo-mesnil