Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): always visible after hover #2338

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

mleralec
Copy link
Contributor

Workaround for this issue: ariakit/ariakit#2929

@mleralec mleralec requested a review from a team as a code owner October 10, 2023 13:40
@github-actions
Copy link

👀 Visit Preview

@mleralec mleralec merged commit 1314666 into master Oct 10, 2023
13 checks passed
@mleralec mleralec deleted the fix-tooltip-always-visible branch October 10, 2023 13:53
Comment on lines 54 to 56
[data-enter] & {
${fadeInStyle}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the bug here is that the CSS transition is not being applied to the tooltip element. The tooltip doesn't hide because it's still waiting for a CSS transition/animation to complete.

You can apply the transition directly to the tooltip element or manually call tooltip.stopAnimation():

<S.FadeIn onTransitionEnd={tooltip.stopAnimation}>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diegohaz Thanks for your answer, I'll check that 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants