Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(breadcrumb): items without link must be disabled #2372

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

mleralec
Copy link
Contributor

@mleralec mleralec commented Dec 12, 2023

Following our design:

  • Item without link must not have "hover" style
  • Active item should have color to dark-700 instead of dark-900
Enregistrement.de.l.ecran.2023-12-12.a.16.24.55.mov

@mleralec mleralec requested review from a team as code owners December 12, 2023 15:25
Copy link

👀 Visit Preview

Copy link
Contributor

@theo-mesnil theo-mesnil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing

@theo-mesnil theo-mesnil marked this pull request as draft December 20, 2023 09:05
@theo-mesnil theo-mesnil added wip and removed approved labels Dec 20, 2023
@mleralec mleralec force-pushed the feat-disable-breadcrumb-item branch 2 times, most recently from 0626f2c to e5853eb Compare December 27, 2023 13:56
@mleralec mleralec changed the title feat(breadcrumb): disable option on item feat(breadcrumb): items without link must be disabled Dec 27, 2023
@mleralec mleralec requested review from theo-mesnil and a team December 27, 2023 13:57
@mleralec mleralec marked this pull request as ready for review December 27, 2023 14:02
@github-actions github-actions bot added to-review and removed wip labels Dec 27, 2023
docs/pages/components/breadcrumb.mdx Outdated Show resolved Hide resolved
@mleralec mleralec force-pushed the feat-disable-breadcrumb-item branch from e5853eb to c51ab20 Compare January 4, 2024 15:46
@mleralec mleralec merged commit 20989fa into master Jan 4, 2024
9 checks passed
@mleralec mleralec deleted the feat-disable-breadcrumb-item branch January 4, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants