Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix <Modal.Footer> type #2398

Closed
wants to merge 1 commit into from
Closed

Fix <Modal.Footer> type #2398

wants to merge 1 commit into from

Conversation

Calvein
Copy link
Contributor

@Calvein Calvein commented Feb 5, 2024

There is no reason for them to be string, and we already pass components in some internal projects, so ReactNode should be better.

@Calvein Calvein requested a review from a team as a code owner February 5, 2024 14:09
Copy link

github-actions bot commented Feb 5, 2024

👀 Visit Preview

@theo-mesnil
Copy link
Contributor

@Calvein it's for translation component ?

@Calvein
Copy link
Contributor Author

Calvein commented Feb 5, 2024

Not in the cases I just fixed, it was something like:

<Box>
  <FormattedMessage />
  <Link />
</Box>

@theo-mesnil
Copy link
Contributor

@Calvein it's a custom footer, i think you need a custom footer too ? We have done this to avoid custom style on footer

@Calvein
Copy link
Contributor Author

Calvein commented Feb 6, 2024

I think you're right, we have a weird mix which is, I'm guessing, due to the migration to the v5, I'll fix it, thanks!

@Calvein Calvein closed this Feb 6, 2024
@theo-mesnil theo-mesnil deleted the fix-modal-information-type branch August 27, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants