Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: typed colors in scene format #198

Merged
merged 8 commits into from
Feb 25, 2024
Merged

Conversation

Walther
Copy link
Owner

@Walther Walther commented Feb 25, 2024

Featire: typed colors in scene format, fixes #68


Slight performance improvement seen, probably due to fewer conversions needed in colorize for each sample, as everything gets converted into Xyz<E> at scene initialization time.

hyperfine --parameter-list branch 2024-02-major-color-refactor,main --command-name {branch} --setup "git switch {branch} && cargo build --release" "cargo run --bin clovers-cli --release -- --input scenes/cornell.json -o renders/temp.png"

Benchmark 1: 2024-02-major-color-refactor (branch = 2024-02-major-color-refactor)
  Time (mean ± σ):     39.790 s ±  0.604 s    [User: 282.476 s, System: 1.038 s]
  Range (min … max):   38.949 s … 41.021 s    10 runs
 
Benchmark 2: main (branch = main)
  Time (mean ± σ):     41.241 s ±  0.583 s    [User: 289.653 s, System: 1.288 s]
  Range (min … max):   40.564 s … 42.408 s    10 runs
 
Summary
  2024-02-major-color-refactor (branch = 2024-02-major-color-refactor) ran
    1.04 ± 0.02 times faster than main (branch = main)

@Walther Walther changed the title Major color refactoring feat: typed colors in scene format Feb 25, 2024
@Walther Walther merged commit 4b2ba85 into main Feb 25, 2024
4 checks passed
@Walther Walther deleted the 2024-02-major-color-refactor branch February 25, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improved Colors
1 participant