remove reference to illegal units #61
Conversation
| @@ -21,7 +21,7 @@ Load("scripts/terran/unit-terran-marine.lua") | |||
| Load("scripts/terran/unit-terran-science-vessel.lua") | |||
| Load("scripts/terran/unit-terran-scv.lua") | |||
| Load("scripts/terran/unit-terran-siege-tank.lua") | |||
| Load("scripts/terran/unit-terran-vulture.lua") | |||
| --Load("scripts/terran/unit-terran-vulture.lua") | |||
There was a problem hiding this comment.
Could be this line: https://github.com/Wargus/stargus/blob/98f45fa7706d72e4c64dec2ce0fbcbd3db27b627/scripts/terran/unit-terran-vulture.lua#L102C19-L102C19 - since @Jarod42 made it now so that units have to start with unit- 😢
There was a problem hiding this comment.
In fact, there was already requirement that units begin with "unit-" at some other places (upgrade/dependencies IIRC).
There was a problem hiding this comment.
I also didn't see a reason in the references lua file why it didn't work. But to get it "fixed" with low effort I just commented it out.
As long as stargus moving is fundamental broken one unit more helps nobody. 😢
There was a problem hiding this comment.
As long as stargus moving is fundamental broken one unit more helps nobody. 😢
well, vulture actually had the handwritten example code that we want to generate, with acceleration etc. and without larva, we cannot produce zerg units :D
There was a problem hiding this comment.
Good point to remember me which unit was the good one. So yes, worth a fix ... in a future PR :-P
| @@ -17,7 +17,7 @@ Load("scripts/zerg/unit-zerg-spore-colony.lua") | |||
| Load("scripts/zerg/unit-zerg-sunken-colony.lua") | |||
| Load("scripts/zerg/unit-zerg-ultralisk-cavern.lua") | |||
|
|
|||
| Load("scripts/zerg/unit-zerg-larva.lua") | |||
| --Load("scripts/zerg/unit-zerg-larva.lua") | |||
There was a problem hiding this comment.
For this one the only interesting thing i see is that it defines the unit types already. But calling DefineUnitType on the same unit ident should be fine, they should just compose, so not sure what the problem might be.
No description provided.