Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make export libraries static #3

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

junaire
Copy link

@junaire junaire commented Aug 21, 2024

t
Signed-off-by: Jun Zhang [email protected]

@junaire
Copy link
Author

junaire commented Aug 21, 2024

we didn't ship libtrain_gpt2_cpu.so when installing wasmedge, so the plugin will never be able to find this library. making the lib static should fix the problem. discovered the issue when testing the rust SDK in my forked repo (https://github.com/junaire/wasmedge-llmc/actions/runs/10483129240/job/29035326617) @hydai

Copy link
Member

@hydai hydai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hydai hydai merged commit a6f9fe8 into WasmEdge:master Aug 21, 2024
16 checks passed
@junaire junaire deleted the jun/make_lib_static branch August 21, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants