Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Feature/expr sig #104

Draft
wants to merge 42 commits into
base: develop
Choose a base branch
from
Draft

WIP: Feature/expr sig #104

wants to merge 42 commits into from

Conversation

dromer
Copy link
Collaborator

@dromer dromer commented Jun 20, 2023

Putting it up for review, even though it's not nearly done yet.

Still needed:

…ode for expr~ prototyped in SignalMath and compiling. Next is to setup front-end plumbing for expr~
@dromer dromer marked this pull request as draft June 20, 2023 05:50
@dromer dromer changed the title Feature/expr sig WIP: Feature/expr sig Jun 20, 2023
@dromer
Copy link
Collaborator Author

dromer commented Jun 24, 2023

@dgbillotte whenever you have time can you check some of the changes I've ported into your branch?

@dromer dromer added enhancement New feature or request help wanted Extra attention is needed labels Jul 18, 2023
@dromer dromer force-pushed the feature/expr-sig branch from d4c5808 to 9ff861f Compare July 19, 2023 22:50
@dgbillotte
Copy link
Collaborator

dgbillotte commented Jul 20, 2023 via email

@dromer
Copy link
Collaborator Author

dromer commented Oct 11, 2023

@dgbillotte did you have a chance to have a look at this again? :)

I do think that we might be painting ourselves a bit into a corner here, as we won't be able to use any of the more recent features of expr~ (like signal objects and others).

However decomposing the expression into a graph might pose additional problems as we'd need to deal with proper control flow as well (particularly for control rate expressions), which is very much non-trivial

So ultimately providing a minimal way to do expr/expr~ might be preferable over trying (and failing) to really decompose the expression into a "proper" heavy graph.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

2 participants