Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed asap7 hacks and updated std cell paths #1

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

ErikFanderson
Copy link

This is an update to the pull request here. My edits:

  1. Removed the methods "generate_multi_vt_gds" and "fix_icg_libs" as these methods are no longer needed with ASAP7's v28 standard cells (as you already noted).
  2. Changed the tarball path to "ASAP7_PDK_CalibreDeck.tar" as this is the name of the tar file provided by ASU.
  3. Updated paths to many of the std cell files from "tech-asap7-cache" to "$STDCELLS". I believe you just forgot to update all of the file paths.
  4. Removed all cells from the "dont use list". This may change as I do further DRC testing.

@Waxpple
Copy link
Owner

Waxpple commented Aug 30, 2022

LGTM!

Changed the tarball path to "ASAP7_PDK_CalibreDeck.tar" as this is the name of the tar file provided by ASU.

The tarball path could be different for anyone. The filename that I have originally is "calibredecks_r1p7.tar.bz2".

Removed all cells from the "dont use list". This may change as I do further DRC testing.

I only dropped the ICG cell because I am sure the original issue is solved. If you have encountered any DRC issues with any cell, you could create a new PR, please.

Thanks!

@Waxpple Waxpple merged commit 90f2ce4 into Waxpple:master Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants