Update background view to use the new view system #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does anyone care about it at all?
ammen99
force-pushed
the
fix-background-view
branch
from
b6454d0
to
1b14098
Compare
ammen99
force-pushed
the
fix-background-view
branch
from
1b14098
to
6c7cf55
Compare
ammen99
force-pushed
the
fix-background-view
branch
from
a834a03
to
db3c314
Compare
|
The necessary Wayfire changes have been merged now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR basically rewrites background-view to properly use the view interfaces provided by Wayfire.
It works by listening to the new pre-map signal. With it, background-view tells core that it will take over the view, so that core destroys its own view associated with the wlroots object (
wlr_xdg_toplevelorwlr_xwayland_surface). Then, background-view creates a new view which is crafted to fit into the requirements of the plugin and appears almost as a layer-shell view to the rest of Wayfire, resulting in its proper treatment by various plugins.