Add sample edition - Iss8 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retrieve server name from env var - Iss11
Add play/pause control from space keyboard key
Avoid adding track with same name - iss5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at implementing part of what is explained in #8.
It is now possible to choose the time start and end of the played sample.
Wavesurfer is used for the visualization, and the Regions plugin is used for editing the start and the end time.
The wave.js file has been added, it includes the
Waveclass and its methods.The interface is bad. I think it would be nice to have this sample time edition hidden by default, and a button for dropping down this time editor for each track.