Added Letterboxd #845
Closed
Added Letterboxd #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebBreacher
reviewed
Aug 7, 2024
| @@ -6560,5 +6560,15 @@ | |||
| "known" : ["carlito", "taylor"], | |||
| "cat" : "social" | |||
| } | |||
| { | |||
| "name" : "Letterboxd", | |||
| "uri_check" : "https://letterboxd.com/{account}", | |||
There was a problem hiding this comment.
Can you add a / to the end of the uri_check as I'm getting redirected without it. So it should be https://letterboxd.com/{account}/
WebBreacher
reviewed
Aug 7, 2024
| "name" : "Letterboxd", | ||
| "uri_check" : "https://letterboxd.com/{account}", | ||
| "e_code" : 200, | ||
| "e_string" : "RECENT ACTIVITY", |
There was a problem hiding this comment.
I tried via web browser and curl and cannot see the RECENT ACTIVITY e_string in any response. I get a good response but don't see that string. I'd suggest using the string ’s profile on Letterboxd which appears in the title tag.
WebBreacher
reviewed
Aug 7, 2024
| @@ -6560,5 +6560,15 @@ | |||
| "known" : ["carlito", "taylor"], | |||
| "cat" : "social" | |||
| } | |||
There was a problem hiding this comment.
You need to change this to be }, please
|
Please also move this to the "L" section of the JSON file right after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Letterboxd