Post thumbnail support #16
Conversation
First pass, nearly complete. Todo: copy thumbnail when post_status changes, i.e. thumbnail added in draft or private
Normally, feature complete. Posts are only synced when they're 'publish', but thumbnails can be added to a post in any status (most commonly, auto-draft). Thumbnails should be synced to the tags blog when the status changes to 'publish'. This is now handled.
|
This is awesome! Great work! I will be testing this ASAP! :D |
|
For information sake, see my comment at #5 (comment) for how, to certain degrees, featured images aren't completely broken with this plugin. They're just handled differently. |
|
Hi Michael,
I did not say that and if that's how you understood my message, I am really sorry. I had read the thread you point to before starting work. What it indicated to me was that people expected post thumbnails to be copied over to the aggregating blog. I know that's what I expected too. So I made it. I understand there is some form of support, but it comes with a lot of drawbacks:
What I'm proposing here removes all these drawbacks. You can now use WP native functions in the aggregating blog for all posts, no matter where they come from. Thumbnails are available in all sizes defined in the aggregating blog. Now, I've probably been a bit agressive in removing the meta fields used in the current method. I'll add them back for backwards compatibility. Would that help? |
|
Understood, and I wasn't offended or anything, just wanting to make sure it's clear to anyone coming by that may read it :) I would definitely say strive for backwards compatibility as much as possible at this point. Regarding some of the points you bring up and try to address, i agree and don't agree. The amount of custom code isn't as great as I think you perceived. Since it was stored as meta data on the aggregated posts, showing things would be as simple as |
|
I agree that not a lot of custom code is needed, but why require custom code at all when it's not necessary? Also, there is still the issue of the image sizes themselves, which may differ between the aggregated and the aggregating blogs. Agree to disagree? ;-) I'll add back the current thumbnail meta fields to the aggregated posts. If I do this, will you consider merging this? |
wds-multisite-aggregate.php
Outdated
| @@ -79,9 +80,11 @@ function hooks() { | |||
| add_action( 'save_post', array( $this, 'do_post_sync' ), 10, 2 ); | |||
| add_action( 'wds_multisite_aggregate_post_sync', array( $this, 'save_meta_fields' ), 10, 3 ); | |||
| add_action( 'wp_update_comment_count', array( $this, 'do_comment_sync' ) ); | |||
| add_action( 'updated_post_meta', array( $this, 'update_thumbnail_meta' ), 10, 4 ); | |||
wds-multisite-aggregate.php
Outdated
| if ( $this->options->get( 'tags_blog_thumbs' ) && ( $thumb_id = get_post_thumbnail_id( $post->ID ) ) ) { | ||
| // Post thumbnail | ||
| if ( $this->options->get( 'tags_blog_thumbs' ) && ( $thumb_id = get_post_thumbnail_id( $post->ID ) ) ) { | ||
| $this->meta_to_sync['thumbnail_url'] = wp_get_attachment_url( $thumb_id ); |
wds-multisite-aggregate.php
Outdated
| } | ||
|
|
||
| // custom taxonomies | ||
| // custom taxonomies |
wds-multisite-aggregate.php
Outdated
| if ( $this->options->get( 'tags_blog_thumbs' ) && !empty( $meta_to_sync[ 'thumbnail_url' ] ) ) { | ||
| $this->set_thumbnail_by_url( $meta_to_sync[ 'thumbnail_url' ], $post_id ); | ||
| unset( $meta_to_sync[ 'thumbnail_url' ]); | ||
| } |
There was a problem hiding this comment.
Matching indent please for the trailing }
|
Gave some quick nitpick comments for some minor details. @mmcachran when you get a chance, can you look over this PR and see if anything stands out for you? Other than that, I have no present problem with merging it in. Would love for some of the people commenting in the issue to give it a test run as well. |
* Code style cleanup (tabs were spaces) * Return of the current thumbnail meta fields added to the aggregated post
The methods I copied and modified were all written by @philipjohn, if I'm to believe the |
|
Still wanting someone besides just me to do a quick code review this before we merge in, for what it's worth. |
|
Hey, I don't have much coding experience so I wouldn't be able to contribute much at all, but I was wondering if you (@brocheafoin ) could add support for scheduled posts. Your code for the plugin file works perfectly when pushing publish on a multisite, but when it is schedule for, say, 10am, the thumbnail will not transfer to the main blog. It works perfectly when straight-out pushing "Publish", but just not when scheduling. Any chance you can help out with that? |
|
Hi @10phillyphan, I wouldn't mind taking a look at it, but I'm also waiting for this pull request to be merged into the main branch. @tw2113, you were looking for more feedback; @10phillyphan here says they've been using this branch successfully. Does that count as enough feedback? Thanks! |
|
@brocheafoin awesome, I appreciate that! Yes, it definitely works for me. No other plugin does exactly what I need it to do, but this one is as close to perfect as it can be. The scheduled post not showing the thumbnail issue is the only thing I still need to be fixed. |
|
For what it's worth, you should be able to pull theirs into yours, without us merging anything first. They would just want to do the PR against yours. Perhaps we could get both merged in at once instead of multiple PRs. just some thoughts. |
|
@streiten is your PR still needed then? or did it end up getting covered here? |
|
for legacy support i guess. when testing the new plugin version with old posts it wasnt covered. |
This fixes issue #5 :
Could be coded more cleanly. All the image stuff in its own class, for example, but I'm pretty sure my code is closer to the coding guidelines than what's already in there, so I'm OK with the current state of affairs. I would really like this to be merged, though, so I'll do what you want. Cheers!
Oh! I forgot. One or two methods were ripped from Automattic's aggregator, so contributors list should be modified accordingly.