Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#284: Add retry-mechanism to threadsRequest-method for stability #285

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

martin-fleck-at
Copy link
Contributor

No description provided.

@WebFreak001
Copy link
Owner

I dislike this fix, retrying after a Cannot execute this command while the target is running error seems like bad practice. It should be possible to do a more reliable fix by inspecting the current state of GDB somehow.

I'm in general not a fan of retrying because of bad timing.

@GitMensch
Copy link
Collaborator

It should be possible to do a more reliable fix by inspecting the current state of GDB somehow.

-thread-info should be possible to get the state, if it says it is still running, then a temporarily -interrupt could be done (but I'd suggest not to do that because it "breaks" until/fin and friends.
If the state says "still running" then the commands to be executed may be placed in a list and executed as soon as we get the stopped event.

@GitMensch
Copy link
Collaborator

After some more debugging: I really think it would be good to at least reliable adjust breakpoints while running.
I've tried to enable GDB's non-stop mode - but it seems the attach doesn't even work correctly afterwards.

This may only leave "interrupt", then "continue" (a change I'll not do myself)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants