Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ssh algorithms, compaitibale with old embedded devices #411

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiaoyun94
Copy link

Add support for ssh algorithms, compaitibale with old embeded devices

@GitMensch
Copy link
Collaborator

Sounds good - can you please add something to the readme for this setting?
Should we also update SSH2 along? This seems to add optional strict key support.

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (26d7d9f) 21.30% compared to head (00a5990) 20.53%.
Report is 8 commits behind head on master.

Files Patch % Lines
src/backend/mi2/mi2.ts 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #411      +/-   ##
==========================================
- Coverage   21.30%   20.53%   -0.77%     
==========================================
  Files          14       14              
  Lines        1737     1802      +65     
  Branches      375      389      +14     
==========================================
  Hits          370      370              
- Misses       1322     1387      +65     
  Partials       45       45              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiaoyun94
Copy link
Author

Sounds good - can you please add something to the readme for this setting? Should we also update SSH2 along? This seems to add optional strict key support.

Sounds good - can you please add something to the readme for this setting? Should we also update SSH2 along? This seems to add optional strict key support.

These parameters i choosed are listed in README.md of mscdex/ssh

@xiaoyun94 xiaoyun94 force-pushed the master branch 2 times, most recently from 70e382d to 00a5990 Compare February 7, 2024 16:11
Copy link
Collaborator

@GitMensch GitMensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do you want to add your change to the CHANGELOG (possibly along with further REAMDE adjustments) or should I pull and do another commit?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@xiaoyun94
Copy link
Author

LGTM.

Do you want to add your change to the CHANGELOG (possibly along with further REAMDE adjustments) or should I pull and do another commit?

I suggest you do that. I am not good at English writing😂

@xiaoyun94 xiaoyun94 changed the title Add support for ssh algorithms, compaitibale with old embeded devices Add support for ssh algorithms, compaitibale with old embedded devices Feb 18, 2024
@xiaoyun94
Copy link
Author

@GitMensch what should i do next

@GitMensch
Copy link
Collaborator

Can you try to update to ssh2 1.15 and retest connecting to your old embedded device please?

@GitMensch
Copy link
Collaborator

For the ChangeLog you can use

-add support for ssh algorithms, compatible with old embedded devices ([@xiaoyun94])

and for the first PR add your entry below "" as well, please.

@GitMensch GitMensch linked an issue Sep 18, 2024 that may be closed by this pull request
@xiaoyun94
Copy link
Author

Can you try to update to ssh2 1.15 and retest connecting to your old embedded device please?

no device available recently, so sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ssh2 dependency does not seem to support older KEX algorithms
3 participants