Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W3C compliance #139

Closed
wants to merge 46 commits into from
Closed

W3C compliance #139

wants to merge 46 commits into from

Conversation

relu91
Copy link

@relu91 relu91 commented Oct 11, 2021

This PR belongs to the new plan of making webthings implementation aligned with the W3C Thing Description specification. Consider this as the first step towards full compliance. Nonetheless, we have already testest the change on actual devices and therefore we've updated the example section with (what we hope) useful guidelines.

Credits: Most of the works have been carried out by @Citrullin.

trivo78 and others added 30 commits July 28, 2021 09:31
change links into forms and minor alligment changes
@rzr
Copy link
Collaborator

rzr commented Oct 11, 2021

may this long serie can be upstreamed into smaller changes PR ?

@Citrullin
Copy link

may this long serie can be upstreamed into smaller changes PR ?

Well, I can make one PR for the compliance and one for the examples. But this would include the changes in ESPWebThingAdapter.h and Thing.h in one PR. I am also not sure, if the existing example would still work with that change.
But, if you wish so and it helps, sure, I can do that.

@relu91
Copy link
Author

relu91 commented Oct 13, 2021

Well, I can make one PR for the compliance and one for the examples. But this would include the changes in ESPWebThingAdapter.h and Thing.h in one PR. I am also not sure, if the existing example would still work with that change.
But, if you wish so and it helps, sure, I can do that.

I was thinking the same, but @rzr you have already a detailed commit history that you can navigate for reviewing. But yeah we can do a single PR containing only the alignments with w3c standard.

@relu91
Copy link
Author

relu91 commented Oct 13, 2021

Ok talked "offline" with @Citrullin, I'm closing this PR and he'll go on and open smaller PRs.

@relu91 relu91 closed this Oct 13, 2021
@rzr
Copy link
Collaborator

rzr commented Oct 13, 2021

ok may it be reopened but I am a bit busy now so I can't do large review that said if you find more reviewers that are ok , I'll be happy to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants