Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glossary support for Google Cloud Translation Advanced #12777

Conversation

gersona
Copy link
Collaborator

@gersona gersona commented Oct 15, 2024

Proposed changes

Added optional glossary support for Google v3 automatic suggestions.
Notable changes include:

  • New bucket_name field for GoogleV3MachineryForm settings form
  • New optional dependency google-cloud-storage

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

fixes #10526

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 98.93617% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.89%. Comparing base (2a851d7) to head (9d1e231).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
weblate/machinery/googlev3.py 97.43% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12777      +/-   ##
==========================================
+ Coverage   90.87%   90.89%   +0.01%     
==========================================
  Files         598      598              
  Lines       61681    61773      +92     
  Branches     6367     6369       +2     
==========================================
+ Hits        56055    56150      +95     
+ Misses       3964     3962       -2     
+ Partials     1662     1661       -1     
Files with missing lines Coverage Δ
weblate/machinery/base.py 93.31% <100.00%> (+0.01%) ⬆️
weblate/machinery/forms.py 96.29% <100.00%> (+0.03%) ⬆️
weblate/machinery/tests.py 99.69% <100.00%> (+0.01%) ⬆️
weblate/machinery/googlev3.py 93.75% <97.43%> (+2.84%) ⬆️

... and 5 files with indirect coverage changes

@gersona gersona marked this pull request as ready for review October 17, 2024 08:26
weblate/machinery/forms.py Outdated Show resolved Hide resolved
@nijel nijel added this to the 5.9 milestone Nov 2, 2024
@nijel
Copy link
Member

nijel commented Nov 13, 2024

The CI failures were caused by not updated lock file with the new dependencies. I've just done that by uv sync --all-extras --no-sources. This needs to be documented and possibly automated by CI (not sure if we can directly run https://github.com/WeblateOrg/weblate/blob/main/.github/workflows/uv-upgrade.yml on pull requests, but I will give it a try).

@nijel nijel self-assigned this Nov 13, 2024
@nijel nijel merged commit 9b23330 into WeblateOrg:main Nov 13, 2024
28 of 29 checks passed
@nijel
Copy link
Member

nijel commented Nov 13, 2024

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Glossary support for Google Cloud Translation Advanced
2 participants