Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Additional format support for translation memory import #12993

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

gersona
Copy link
Collaborator

@gersona gersona commented Nov 12, 2024

Proposed changes

Extend memory translation upload support to formats other than JSON and TMX with automatic format detection and content parsing. Other files usually require that source_language and target_language are passed as arguments

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 97.53086% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.89%. Comparing base (0239904) to head (c0835d2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
weblate/memory/models.py 92.85% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12993      +/-   ##
==========================================
+ Coverage   90.87%   90.89%   +0.02%     
==========================================
  Files         598      598              
  Lines       61681    61758      +77     
  Branches     6367     6376       +9     
==========================================
+ Hits        56055    56138      +83     
+ Misses       3964     3960       -4     
+ Partials     1662     1660       -2     
Files with missing lines Coverage Δ
weblate/memory/forms.py 100.00% <100.00%> (ø)
...eblate/memory/management/commands/import_memory.py 100.00% <100.00%> (ø)
weblate/memory/tests.py 100.00% <100.00%> (ø)
weblate/memory/views.py 95.97% <ø> (ø)
weblate/memory/models.py 84.87% <92.85%> (+2.29%) ⬆️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility to import the translation memory in formats different from TMX and JSON
1 participant