Changed needs for find_hits in test_ accordingly

WenzDaniel · Feb 17, 2020 · c963fdc · c963fdc
1 parent b549150
commit c963fdc
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/tests/test_data_reduction.py b/tests/test_data_reduction.py
@@ -7,7 +7,17 @@
 @settings(deadline=None)
 @given(single_fake_pulse)
 def test_cut_outside_hits(records):
-    hits = strax.find_hits(records, threshold=0)
+    default_thresholds = np.zeros(248,
+                                  dtype=[(('Hitfinder threshold in absolute adc counts above baseline',
+                                           'absolute_adc_counts_threshold'), np.int16),
+                                         (('Multiplicator for a RMS based threshold (h_o_n * RMS).',
+                                           'height_over_noise'),
+                                          np.float32),
+                                         (('Channel/PMT number', 'channel'), np.int16)
+                                         ])
+    default_thresholds['channel'] = np.arange(0, 248, 1, dtype=np.int16)
+
+    hits = strax.find_hits(records, threshold=default_thresholds)
 
     # Set all record waveforms to 1 (still and 0 out of bounds)
     for r in records:

diff --git a/tests/test_pulse_processing.py b/tests/test_pulse_processing.py
@@ -8,7 +8,16 @@
 
 
 def _find_hits(r):
-    hits = strax.find_hits(r, threshold=0)
+    default_thresholds = np.zeros(248,
+                                  dtype=[(('Hitfinder threshold in absolute adc counts above baseline',
+                                           'absolute_adc_counts_threshold'), np.int16),
+                                         (('Multiplicator for a RMS based threshold (h_o_n * RMS).',
+                                           'height_over_noise'),
+                                          np.float32),
+                                         (('Channel/PMT number', 'channel'), np.int16)
+                                         ])
+    default_thresholds['channel'] = np.arange(0, 248, 1, dtype=np.int16)
+    hits = strax.find_hits(r, threshold=default_thresholds)
     # Test pulses have dt=1 and time=0
     # TODO: hm, maybe this doesn't test everything
     np.testing.assert_equal(hits['time'], hits['left'])