Merge pull request #10 from WesleyBranton/development

Version 1.6.2
WesleyBranton · Nov 25, 2019 · 360629f · 360629f
2 parents 424c7ee + f73b1e3
commit 360629f
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -18,6 +18,11 @@ To develop and test the extension, you need to open the "about:debugging" page i
 Further documentation about developing Firefox extensions can be found [here](https://developer.mozilla.org/docs/Mozilla/Add-ons/WebExtensions/Your_first_WebExtension).
 
 ## Release Notes
+### Version 1.6.2
+* **[FIXED]** Issue with options UI appearance
+* **[FIXED]** Error when changing settings
+* **[FIXED]** Error when installing add-on for the first time
+
 ### Version 1.6.1
 * **[CHANGE]** Overhauled options UI
 

diff --git a/firefox/background.js b/firefox/background.js
@@ -108,13 +108,14 @@ function storageChange(changes) {
 
     if (changes.volume) {
         chimeVolume = changes.volume.newValue;
-        audio.volume = chimeVolume;
+        if (audio) {
+            audio.volume = chimeVolume;
+        }
     }
 }
 
 var chimeName, chimeVolume, audio;
 firstLoad();
-browser.runtime.onInstalled.addListener(handleInstalled);
 browser.alarms.onAlarm.addListener(hourTrigger);
 chrome.runtime.onMessage.addListener(listenMessage);
 browser.storage.onChanged.addListener(storageChange);

diff --git a/firefox/manifest.json b/firefox/manifest.json
@@ -1,7 +1,7 @@
 {
     "manifest_version": 2,
     "name": "Grandfather Fox",
-    "version": "1.6.1",
+    "version": "1.6.2",
     "description": "Turn Firefox into a grandfather clock that plays a tune at the top of each hour!",
 
     "icons": {

diff --git a/firefox/options/options.html b/firefox/options/options.html
@@ -6,16 +6,17 @@
 <html>
     <head>
         <meta charset="utf-8">
-        <link rel="stylesheet" href="../lib/preferences/style.css">
+        <link rel="stylesheet" href="../lib/new_browser_style.css">
     </head>
-    <body>
+    <body class="browser-style">
         <form name="settings">
             <section class="panel-section">
                 <label>Chime volume (<label id="volumeOutput">100%</label>)</label>
                 <div>
                     <input type="range" min="1" max="100" value="100" name="volume" id="chimeVolume">
                 </div>
             </section>
+            <div class="panel-section-separator"></div>
             <section class="panel-section">
                 <label>Chime sound</label>
                 <select id="chimeNoise" name="noise">
@@ -26,10 +27,12 @@
                     <option value="singlebeep">Single Beep</option>
                 </select>
             </section>
+            <div class="panel-section-separator"></div>
             <section class="panel-section">
                 <label>Preview chime</label>
                 <button type="button" id="sample" class="button default">Listen</button>
             </section>
+            <div class="panel-section-separator"></div>
             <section class="panel-section has-help">
                 <label>Fix timing</label>
                 <button type="button" id="reload" class="button secondary">Fix</button>