mod: Component and SceneModule .add .remove #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasha240100
reviewed
Apr 25, 2018
| this.children.splice(this.children.indexOf(object), 1); | ||
| }, | ||
| _setScene(scene) { | ||
| this.children = scene[SYMBOL_CHILDREN_FOR_SCENE] = scene[SYMBOL_CHILDREN_FOR_SCENE] || [] |
There was a problem hiding this comment.
Hey, thanks for the PR! Everything seems good. Can you explain me why do we use Symbol here? And I'll merge it 😀
There was a problem hiding this comment.
The scene is a THREE.Scene object. We need store this.children in the object. If we use scene._varName = this.children, there is a risk that the three.js team may use _varName in THREE.Scene later. But in general, Symbol is safe.
There was a problem hiding this comment.
@BrookShuihuaLee Ok, thanks for explanation! Also, could you contact me in discord for further cooperation?
There was a problem hiding this comment.
@sasha240100 ok, i've sent you a friend request 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.